Giter Site home page Giter Site logo

Comments (10)

Vincent-Maladiere avatar Vincent-Maladiere commented on June 21, 2024 1

Hey @dcor01, example 3 is already solved, but you can focus on example 4.

from skrub.

dcor01 avatar dcor01 commented on June 21, 2024 1

Changed the filter warnings in example 4 in #808

from skrub.

Vincent-Maladiere avatar Vincent-Maladiere commented on June 21, 2024 1

Thank you @dcor01 and @Tialo, closing the issue :)

from skrub.

Tialo avatar Tialo commented on June 21, 2024

https://github.com/skrub-data/skrub/blob/main/skrub/_fuzzy_join.py#L359

If it warns whenever used, probably it's bad idea to remove filterwarnings.

from skrub.

Tialo avatar Tialo commented on June 21, 2024

There is also warning in https://skrub-data.org/stable/auto_examples/02_investigating_dirty_categories.html

I can fix it if necessary.

from skrub.

Vincent-Maladiere avatar Vincent-Maladiere commented on June 21, 2024

main/skrub/_fuzzy_join.py#L359

If it warns whenever used, probably it's bad idea to remove filterwarnings.

Indeed, we plan to remove warnings.warn("This feature is still experimental.") since the entire package is experimental.

from skrub.

Vincent-Maladiere avatar Vincent-Maladiere commented on June 21, 2024

There is also warning in skrub-data.org/stable/auto_examples/02_investigating_dirty_categories.html

I can fix it if necessary.

That would be great, you can go ahead and create a PR!

from skrub.

dcor01 avatar dcor01 commented on June 21, 2024

Hi guys, I'm hoping to try and fix these warnings in example 3 and 4

from skrub.

dcor01 avatar dcor01 commented on June 21, 2024

I have made a pull request let me know your thoughts. #807

I also made a few capitalisation changes in example 4.

from skrub.

dcor01 avatar dcor01 commented on June 21, 2024

Changed the filter warnings in example 4 in #808

from skrub.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.