Newlines in logs

[skx]

Newlines in logs

[matejzero]

Will take a look at CSS and try to create something nice:P

[skx]

Yes I've noticed the same thing. It's a frustrating issue because the obvious solution is just to wrap the output in a <pre> + </pre> block. But that looks bad for some cases too.

I've never quite sat down and gone through all the output but I think that it is probably worth defaulting to the wrapping, and then selectively disabling it.

[skx]

If you can build from source - and regenerate the bindata.go file, as documented in HACKING.md - then this change should be all that is required:

  diff --git a/data/report.template b/data/report.template
  index 83e0c2f..6626274 100644
  --- a/data/report.template
  +++ b/data/report.template
  @@ -63,7 +63,7 @@
             <div class="col-sm-1 col-md-1">
             </div>
             <div class="col-sm-11 col-md-11">
  -            {{range .LogMessages}}
  +            <pre>{{range .LogMessages}}</pre>
               <p>{{.}}</p>
               {{else}}
               <p>Nothing reported.</p>

I'll commit that as a new release this evening.

[matejzero]

Sure, I'll give it a go and report:)

[matejzero]

This looks way better. But I needed to set <pre> one line lower:

  diff --git a/data/report.template b/data/report.template
  index 83e0c2f..6626274 100644
  --- a/data/report.template
  +++ b/data/report.template
  @@ -63,7 +63,7 @@
             <div class="col-sm-1 col-md-1">
             </div>
             <div class="col-sm-11 col-md-11">
              {{range .LogMessages}}
  -            <p>{{.}}</p>
  +            <pre><p>{{.}}</p></pre>
               {{else}}
               <p>Nothing reported.</p>

We could do some CSS modification as well to lower the line-heigh inside <pre> to get rid of extra blank space under the text:P.

[skx]

D'oh. That's what happens when I make a quick diff without compiling/testing!

CSS change is probably reasonable too :)

[matejzero]

I see you are loading CSS from CDN. What would be the best way to do modifications? Inline CSS or extra .css file?

As far as changes go, it looks OK to me if I change:

p:
  margin: 0; (default 0 0 10px)
pre:
  padding: 5px 9px; (default 9,5px)

[skx]

I'd probably place it in-line to avoid having to write a handler to serve "/extra.css".

(If the change were more general I'd probably make the other decision, but since this is only a change useful for pre tags, which will only show up in the report-view I think inline is fine.)

[matejzero]

Nice.

If you don't mind, I can create a PR.

[skx]

Please do feel free. I'll not be home for a good few hours and if there is one waiting for me I can bundle it up with a new release quickly enough.

[matejzero]

PR created.

I've testing it and it looks OK on my side. Try it yourself too and merge if you think it's good:)

[skx]

The change looks good - but it doesn't show up as a PR against this repository...

[matejzero]

Sorry, I just edited the file via web and didn't look where PR landed. Fixed that.

[skx]

Closed in #41 - much appreciated. I'll sort out a new release shortly.