Giter Site home page Giter Site logo

Comments (3)

abjerner avatar abjerner commented on September 3, 2024

@Ornhoj any problems with our frontend if we change mode from pad to crop?

I think we once settled on pad as default, and then the frontend would switch to crop instead if needed in a particular context.

The problem is however that information about the anchor or focal point isn't included in the URL when mode is pad as the image then isn't cropped, but only resized/padded.

Or would it be better to skip the cropUrl property entirely, and then return the focal point through a new property instead? Then the frontend will have all the information needed to concatenate the URL.

from skybrud.imagepicker.

Ornhoj avatar Ornhoj commented on September 3, 2024

Future development should properly support both cases, but for know change the mode - it will be a non-breaking change

from skybrud.imagepicker.

abjerner avatar abjerner commented on September 3, 2024

@rpjengaard new release is here: https://github.com/skybrud/Skybrud.ImagePicker/releases/tag/v2.0.0-alpha002

I've only changed the mode from pad to crop for now. I haven't included information about the focal point in it's own property, which we'd want for the future - so I'll leave the issue open until I have the time to look into that ;)

from skybrud.imagepicker.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.