Giter Site home page Giter Site logo

Comments (5)

skydoves avatar skydoves commented on May 21, 2024

Hi, so do you mean it would be good if the onFailure extension takes the actual instance instead of the message like the other extensions?

from sandwich.

nonproto avatar nonproto commented on May 21, 2024

I believe so. Using my example above.
the onError{} provides the ApiResponse.Failure.Error<LoginResponseDto>
the onException{} provides the ApiResponse.Failure.Exception<LoginResponseDto>

it would be nice if
onFailure{} provided ApiResponse.Failure

so then the user could decide if they want to use toString() to get the message, or handle the actual error/exception response directly.

from sandwich.

skydoves avatar skydoves commented on May 21, 2024

Thank you for the details. It's available on the new snapshot version 1.2.5-SNAPSHOT. If you feel it's good, I will release the next version very soon. Thanks!

from sandwich.

nonproto avatar nonproto commented on May 21, 2024

Yep this works!

from sandwich.

skydoves avatar skydoves commented on May 21, 2024

Sandwich 1.2.5 was released! Thanks for reporting this issue :)

from sandwich.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.