Comments (22)
Thanks @Jeepston for your feedback. I'll fix that on iPad too. Give me few days.
from actionsheetpicker-3.0.
I have the same problem and noticed #528. But it have not been merged when 2 month passed
from actionsheetpicker-3.0.
After #528 is merged, this issue will be fixed
from actionsheetpicker-3.0.
I hadn't seen .tapDismissAction in the API, so wasn't using it. I have updated my code to set it to .cancel, but (as I assume you know) I still didn't get notified when the user tapped above the action sheet. Not reported here, the same thing happens in popover mode on an iPad. Let me know if you want me to create a separate issue for the iPad popover problem.
from actionsheetpicker-3.0.
I confirm: tapDismissAction is not called, if it is not .none. I've tracked it to the fact that when adding gesture recognisers in AbstractActionSheetPicker showActionSheetPicker. _actionSheet.window is always nil, since SWActionSheet window is never called
from actionsheetpicker-3.0.
@Jeepston I agree, my branch #528 is not yet merged so you're facing the issue.
Can you please specify my branch in your Podfile for ActionSheetPicker and test once?
from actionsheetpicker-3.0.
@noorulain17 I would be happy to, if you provide me with the instructions how to specify a brunch in Podfile (never done it before)
from actionsheetpicker-3.0.
Hey @Jeepston
you can use the following code to test on your app
pod 'ActionSheetPicker-3.0', :git => 'https://github.com/skywinder/ActionSheetPicker-3.0.git', :branch => 'broken_tapDismissAction_fix'
You can learn more about changing branch/tag, etc. in Podfile
from here
from actionsheetpicker-3.0.
@noorulain17 I've tested your branch - the fix works on iPhones, but unfortunately, not on iPads...
from actionsheetpicker-3.0.
The PR is pending, #528 would easily solve it.
from actionsheetpicker-3.0.
I'm having this issue too has it been fixed
from actionsheetpicker-3.0.
@hechukwu the fix has been merged to develop
branch, you can test is using
pod 'ActionSheetPicker-3.0', :git => 'https://github.com/skywinder/ActionSheetPicker-3.0.git', :branch => 'develop'
@skywinder or I will release a new version of the library in a few days
from actionsheetpicker-3.0.
Thank you
from actionsheetpicker-3.0.
Didn't seem to work. When I tap outside the action sheet and it dismisses when I try to open it again it doesn't work
from actionsheetpicker-3.0.
if !pickerIsActive {
pickerIsActive = true
let subspaceName = self.subspaces.map { $0.name }
let title = subspaces.count == 0 ? "There are no subspaces" : "Select Subspace"
let initialIndex = 0
let picker = ActionSheetStringPicker.show(withTitle: title, rows: subspaceName as [Any], initialSelection: initialIndex, doneBlock: { picker, index, value in
self.pickerIsActive = false
if let subspaceName = value as? String {
self.subspaceTextField.text = subspaceName
self.selectedSubspace = self.subspaces[index]
}
return
}, cancel: { actionMultipleStringCancelBlock in
self.pickerIsActive = false
return
}, origin: self.spaceTextField)
if #available(iOS 13.0, *) {
picker?.toolbarButtonsColor = .label
picker?.pickerBackgroundColor = .systemGray6
picker?.toolbarBackgroundColor = .systemGray6
picker?.titleTextAttributes = [NSAttributedString.Key.foregroundColor : UIColor.label]
}
}
from actionsheetpicker-3.0.
@noorulain17 I'm using the branch but it's still not working
from actionsheetpicker-3.0.
@hechukwu thanks for the update. I'll work on this on the weekend.
Or if you would like to open the fix PR, you're more than welcome :)
Thanks for using ActionSheetPicker.
from actionsheetpicker-3.0.
@noorulain17 sure thing bro. This is a great tool been using for most of my projects.
from actionsheetpicker-3.0.
@noorulain17 Thanks for the reply. It seems this issue is not fixed on iPhone or iPad. Please help to fix/merge the code if possible. Thanks!
from actionsheetpicker-3.0.
Any update on this? thanks.
from actionsheetpicker-3.0.
Related Issues (20)
- Minimum iOS version HOT 8
- ios 14 issue display picker only one date ? HOT 13
- Cannot use the library if is installed using Swift Package Manager
- tapDismissAction broken after 2.5.1 HOT 3
- Data Linkage with ActionSheetMultipleStringPicker HOT 2
- SWActionSheetVC.dismissTap prevents calendar from working in inline style
- OK Button Locale not change HOT 3
- Current date is not available on compact Date picker style iOS 14.4 & above HOT 1
- Exclude days or dates
- "exported: true has no effect in '_specialize' attribute" Issue at Xcode 12.5 HOT 3
- Not working with Swift Package Manager [bug] HOT 5
- Remove the pieces of the code for less than the Deployment Target HOT 3
- Picker not showing on iPad but only on iPhone HOT 1
- Picker not appearing if try to show back to back
- ActionSheet opens in wrong display when iphone is connected to an external display.
- Mac Catalyst Warnings HOT 1
- SPM Issues HOT 1
- Adjust Picker Width HOT 2
- Unable to build archieve on Xcode 14.3 HOT 11
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from actionsheetpicker-3.0.