Giter Site home page Giter Site logo

Comments (4)

skywinder avatar skywinder commented on August 17, 2024

CountDownTimer is quite new feature for ActionSheetPicker, that implemented in #50.
I think it's need to do some improvements of this feature as you described in this issue.

from actionsheetpicker-3.0.

mgmart avatar mgmart commented on August 17, 2024

Good to know. I'll wait for that :-)

Thanks for your effort!

from actionsheetpicker-3.0.

mgmart avatar mgmart commented on August 17, 2024

Couldn't wait :-)

The issue with the additional hour is addressed in #74.

The value which with the action block is called is a double wrapped in NSNumber.
This is unfortunately not so easy to see in Swift.

from actionsheetpicker-3.0.

jklp avatar jklp commented on August 17, 2024

Hi @mgmart, I'm the one who fixed up #50 (as mentioned by @skywinder) and have looked through your changes and think you're right - in that you need to set "duration" instead of the "minuteInterval" on the ActionSheetDatePicker.

The diff also looks good and same with the new constructor for setting the initial duration.

Re: The action callback returning an NSTimeInterval (which is a double) instead of an NSDate, I think this is correct behaviour though, as I'm not sure how else you'd represent the number of minutes the user has selected using an NSDate?

@skywinder - up to you how you want to proceed

from actionsheetpicker-3.0.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.