Giter Site home page Giter Site logo

Comments (6)

Kinphi avatar Kinphi commented on August 17, 2024

found the solution:

id (*response)(id, SEL, id, id,id) = (id (*)(id, SEL, id, id,id)) objc_msgSend;
    response(target, action, [NSNumber numberWithInteger:(NSInteger)bigUnits],[NSNumber numberWithInteger:(NSInteger)smallUnits], origin);

from actionsheetpicker-3.0.

skywinder avatar skywinder commented on August 17, 2024

Wait, while it not fixed - it's too early to close this issue.
If you found solution, I would be pleased, if you create a pull request.
Can you explain, how to reproduce this crush?
only on 7.1? simulator or device? steps to reproduce?

from actionsheetpicker-3.0.

Kinphi avatar Kinphi commented on August 17, 2024

i only test in ios 7.1.but serval device,4s,5,5s.only 5s will crash.
simulator i only test in 32bit...for some kind of reason i cant text in 64bit in simulator.
when i use my method to catch the parameter which create by

  • (void)notifyTarget:(id)target didSucceedWithAction:(SEL)action origin:(id)origin
    it carshed.
    the crash point is at

line 120

objc_msgSend(target, action, [NSNumber numberWithInteger:(NSInteger)bigUnits], [NSNumber numberWithInteger:(NSInteger)smallUnits], origin);

when i use

id (response)(id, SEL, id, id,id) = (id ()(id, SEL, id, id,id)) objc_msgSend;
response(target, action, [NSNumber numberWithInteger:(NSInteger)bigUnits],[NSNumber numberWithInteger:(NSInteger)smallUnits], origin);

to replace the old one,it works fine in 5s.

from actionsheetpicker-3.0.

skywinder avatar skywinder commented on August 17, 2024

Thanks a lot!
You can find your update in version 1.0.9

BDW, a couple additions to your solution:

void (*response)(id, SEL, id, id,id) = (void (*)(id, SEL, id, id,id)) objc_msgSend;

  1. remove redundant cast
  2. change id to void - otherwise it will be crash on 32-bit devices.

from actionsheetpicker-3.0.

skywinder avatar skywinder commented on August 17, 2024

Fixed in 5a11f0b

from actionsheetpicker-3.0.

skywinder avatar skywinder commented on August 17, 2024

Also, ActionSheetDistancePicker still looks not so good on iOS 7 (cm text is misaligned- see TimCinel#108)
I spend a day to just make it works and not crash on iOS 7.
And have no time to align this label.
Sorry for that.

from actionsheetpicker-3.0.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.