Giter Site home page Giter Site logo

Comments (7)

PranayAgarwal avatar PranayAgarwal commented on May 18, 2024 1

Yeah, that will work. If the config isn't set, the extension can show a pop-up with yes/no options, and that value can get saved.

from vscode-hack.

fredemmott avatar fredemmott commented on May 18, 2024 1

Got a complete change ready for this, just waiting for FB process to say I can send a PR (FB: T31296958 P59796946)

from vscode-hack.

PranayAgarwal avatar PranayAgarwal commented on May 18, 2024

I'm thinking this could be enabled by default (with an opt-out config) if $ROOT/vendor/bin/hhast-lint is present in the workspace. Thoughts?

from vscode-hack.

fredemmott avatar fredemmott commented on May 18, 2024

My concern is that vscode $(pwd) then executes arbitrary code

from vscode-hack.

fredemmott avatar fredemmott commented on May 18, 2024

Is it possible to pop up a dialog confirming whenever a project is opened with vendor/bin/hhast-lint? If so, that would be my preference - with it remembering per-$ROOT

from vscode-hack.

fredemmott avatar fredemmott commented on May 18, 2024

just checking: that configuration can be stored outside the project root, right?

I.e. I can't make a malicious project bypass the prompt by also commiting a vscode config to my project?

from vscode-hack.

fredemmott avatar fredemmott commented on May 18, 2024

PR #25

from vscode-hack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.