Giter Site home page Giter Site logo

Comments (7)

Fedcomp avatar Fedcomp commented on July 29, 2024 5

I just ran into this. It would be nice to have application.rb/environments config so it would feel well integrated into rails.

The second proposal however is not an option since Slim/Temple brings its own configuration framework independant of rails.

It doesn't have to inherit rails configuration, it may have simple class which will proxy all configuration calls to slim engine.

In pseudocode:

class SlimRailsConfigProxy
  def method_missing(method, args)
    if Slim::Engine.options.respond_to?(method)
      Slim::Engine.options.send(method, args)
    else
      raise ArgumentError, "Slim does not have option #{method}"
    end
  end
end

@minad may you reconsider your decision? would you accept PR of such functionality?

from slim-rails.

januszm avatar januszm commented on July 29, 2024 2

@Fedcomp sounds good. I'm the current maintainer of this gem, let's work on a new PR for this functionality.

from slim-rails.

minad avatar minad commented on July 29, 2024

The pretty proposal is reasonable. The second proposal however is not an option since Slim/Temple brings its own configuration framework independant of rails.

from slim-rails.

korzhyk avatar korzhyk commented on July 29, 2024

I think it's a good idea, because we have a "slim-rails", and support rails configuration will be good for rails applications.

from slim-rails.

johnnyshields avatar johnnyshields commented on July 29, 2024

+1 👍

from slim-rails.

Fedcomp avatar Fedcomp commented on July 29, 2024

Okay thanks! i'll try to make a PR this or next weekend.

from slim-rails.

Fedcomp avatar Fedcomp commented on July 29, 2024

@januszm sorry. Unfornately when i found time to work on it, i ran into incompatibility with rails 3, and left no time and willing to resolve it. And i'll probably stop.

from slim-rails.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.