Use of type hints and return types

[slimphp]

Use of type hints and return types

[l0gicgate]

I’m all for type hinting and return types to be as strict as possible. The problem is that most of the implementations have to match the function signatures from the PSR-7 interfaces which are not type hinted.

[holtkamp]

The problem is that most of the implementations have to match the function signatures from the PSR-7 interfaces which are not type hinted.

Ah, of course 🤦‍♂

This applies for the parameters, but for the "return types" I believe it should be able to increase strictness...

This might be useful to use: https://www.tomasvotruba.cz/blog/2018/12/10/rocket-science-behind-migration-of-docblock-types-to-php-typehints/#give-your-code-a-typehint-facelift

[holtkamp]

To get an impression, an experimental commit: holtkamp@3934b95

PHPUnit fails, but this seems not related to the types / also fails on a clean clone.