Problem with Windows

[slimphp]

Problem with Windows

[bobdia]

Perhaps the built-in DIRECTORY_SEPARATOR constant would be handy.

[codeguy]

@bobdia Perhaps. In this case, Request::$root is the public-accessible URI to the directory in which the Slim app is installed. Most of the times, this will be "/", but it could be "/foo" or "/foo/bar" and so on. I believe DIRECTORY_SEPARATOR will be "" on Windows so not necessarily useful when constructing URIs. This should be an easy fix... just need to get to it here soon is all.

[bobdia]

Just thought I'd mention it. "/" will work on windows so should be simpler to always use that. Let me know if you need someone to test on Windows.

[codeguy]

Absolutely. I'll post another message here when I push up the changes so you can test. Thanks!

[codeguy]

I'm not at all familiar with IIS, and I believe this issue is specific to that server. If anyone else can chip in and provide a solution for this, that'd be much appreciated. Until then, I'm lowering the priority of this ticket.

[phaseinducer]

I run a WAMP server with the latest dev version and I had a similar problem : my URI root was "" so all my generated URLs were incorrect. This is due to the different behaviour of dirname() on Windows, called in Uri::getBaseUri() (line 71).

I fixed it like this :
$baseUri = strpos($requestUri, $scriptName) === 0 ? $scriptName : dirname($scriptName);

replaced by :
$baseUri = strpos($requestUri, $scriptName) === 0 ? $scriptName : str_replace('', '/', dirname($scriptName));

It's not very pretty but effective.
I tested it with and without a controller call and also with the app installed in a sub-directory.

[codeguy]

Nice! If you want to send a pull request I can pull your code and credit you with the change. Else I'll add this in myself later today.

[phaseinducer]

I have no fork for the moment so you can make the change, yes.

[codeguy]

Pulled in, pushed to master and develop.