Comments (7)
Isn't it actually better to have all the hashes explicitly baked in the Docker image though? It seems that relying on github actions would make it harder to track down exactly which versions are being used. GH actions are also basically impossible to run locally, while it's trivial to run a docker container locally that would execute exactly the same steps that CI would also run.
from slsa-github-generator.
From that angle, I think you're right. Actions can be pinned by hash, so I guess we'd need to check how setup-go works under the hood and make sure it does pin what it downloads :-) That may be a good exercise in itself to see if it's do-able in general.
But I suspect Docker is easier :-)
Thanks for chiming in!
from slsa-github-generator.
I think we should re-write detect-workflow
to TypeScript since it's essentially building a Docker image each run just so we can make a single HTTP request. We can speed it up a lot by re-writing it to a JavaScript action.
from slsa-github-generator.
I'm onboard with removing it and replacing with TS
from slsa-github-generator.
Note that once we have released the generic container workflow, we can improve speed by using a container-based Action, like https://github.com/ossf/scorecard-action/blob/main/action.yaml#L54-L56.
For transparency, we can keep the SLSA attestation in the repository and add pre-submit that the hash of the attestation is the same as the one used by the action's container. We could later use the slsa-verifier when it's ready.
Not saying we cannot use TS long-term, but if speed is the main issue now, we can use the suggestion above instead.
Wdut?
from slsa-github-generator.
Note that once we have released the generic container workflow, we can improve speed by using a container-based Action, like https://github.com/ossf/scorecard-action/blob/main/action.yaml#L54-L56.
Yeah, that's one way to do it. It's a bit more work to set up a place to store the images and the CI for it, but we could probably just use GHA/ghcr.io for that.
from slsa-github-generator.
I was thinking of using ghcr.io for it.
from slsa-github-generator.
Related Issues (20)
- [e2e]: maven workflow_dispatch main default slsa3 HOT 1
- [e2e]: generic push main upload-tag-name slsa3 HOT 1
- [e2e]: generic schedule main default slsa3 HOT 1
- [e2e]: generic tag main goreleaser-assets-multi-subjects slsa3 HOT 1
- [e2e]: container-based schedule main registry-username HOT 1
- [feature] Refactor Hall of Fame badges so that future additions and changes are easier to manage HOT 2
- [feature] Comparison to new GitHub Artifact Attestations? HOT 10
- [e2e]: container-based schedule main registry-username HOT 1
- [e2e]: go tag main config-ldflags-assets slsa3 HOT 1
- [feature] Update actions/setup-go and google-github-actions/auth to avoid Node.js 16 deprecation warnings HOT 5
- [e2e]: delegator-lowperms release main default slsa3 HOT 1
- [e2e]: generic release main default slsa3 HOT 1
- [e2e]: delegator-generic release main default slsa3 HOT 1
- [docs] Add inputs to provenance examples
- [refactor] Add SLSA token interface to a tscommon.
- [bug] Renovate seems broken HOT 4
- [e2e]: delegator-lowperms create main default slsa3 HOT 1
- [e2e]: delegator-lowperms tag main default slsa3 HOT 1
- [e2e]: maven workflow_dispatch main default slsa3 HOT 1
- [e2e]: go tag main config-ldflags-assets-tag slsa3 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from slsa-github-generator.