Comments (8)
I can try to maintain both, but it gets pretty tricky when you're trying to import from react-leaflet v2 and react-leaflet v3 in the same codebase. I use the transform-rename-import
babel plugin to get it done, but I guess its not working exactly as expected. Maybe I'll just keep support for RLV2 alive in a specific version. Thanks for using the plugin, LMK if you run into any other issues.
from react-esri-leaflet.
Interesting. I think I know what the issue is. Might take me some time to fix and test before I can publish an update. Are you not able to update your project to use react-leaflet v3? Would probably solve your problem much quicker and keep your project up to date...
from react-esri-leaflet.
Not at the moment, we use several react-leaflet plugins and they don't all support v3. I'd use version 1.0.3 of this library in the meantime but there's an issue with its license.
from react-esri-leaflet.
I just noticed that the license in npm (ISC) does not match the one in the repo (MIT and GPL previously). Would we be able to use the older version with the ISC license?
from react-esri-leaflet.
Yes, someone else had asked about that, that's why I changed the license. I love when people use my stuff, so I give you explicit permission to use 1.0.3 (or any version you like) with MIT....I'm not sure why npm is listing it as ISC. Is there a difference to you as far as ISC vs MIT? I'm not sure how to go back and change the license of a previous version, which is why I bumped it from 1.3.0 to 1.3.1. I'm still trying to isolate what change happened after 1.0.3 that is causing your problem...
from react-esri-leaflet.
Thank you very much! MIT and ISC are essentially identical AFAIK. You'll have to change the license
field in package.json
to "MIT"
and publish a new version for it to reflect in npm.
from react-esri-leaflet.
I just went back and publish a 1.0.4, which is essentially just 1.0.3, with the license changed to MIT. Here's a sandbox with that: https://codesandbox.io/s/react-esri-leaflet-v2-forked-pe7q8
Hopefully that gets your the latest features I had put in up to that point, with the license you need
I suspect the issue is actually in transpilation. It was at that point that I switched from a total babel-based approach, to one that mixes typescript tsc
and babel. I was more focused on react-leaflet-v3 and esri-leaflet-v3 than keeping up to date with v2 of anything. Hopefully 1.0.4 gives you what you need. Keep me posted...I'm not sure I'm going to continue supporting v2 of anything in the future...
from react-esri-leaflet.
That's perfect, thanks! I would hope support for v2 remains in some form, as v3 support is still not fully widespread with other plugins, and v3 of react-leaflet also uses a non-standard license (Hippocratic).
from react-esri-leaflet.
Related Issues (15)
- Warning about Identify in esri-leaflet creating multiple callback scripts HOT 3
- Control (Add and remove) <FeatureLayer> on Checkbox OnChange HOT 5
- Add support to new flag ignoreDeprecationWarning from esri-leaflet > v3.0.2 HOT 8
- Issue with refs + Typescript (TiledMapLayer) HOT 5
- Can't change basemap layer HOT 2
- BasemapLayer is deprecated HOT 1
- Uncaught ReferenceError: y is not defined (Production) HOT 1
- "Suggestions" show different results than the actual "results" HOT 1
- Geosearch Multiple Providers of same type ? HOT 4
- Could not resolve dependency: [ react-esri-leaflet , esri-leaflet , esri-leaflet-vector ] HOT 8
- "build" command does not transpile output HOT 3
- Question: how to use setWhere or equivalent with a FeatureLayer❓ HOT 8
- Add Support for Esri Leaflet Renderers HOT 8
- Cannot useRef with functional components HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-esri-leaflet.