Giter Site home page Giter Site logo

Comments (34)

digital-phoenix avatar digital-phoenix commented on June 16, 2024 1

I think I have implemented all the requirements for this issue.
I will post the code soon.
Let me know if you have any questions.

from refact-lsp.

digital-phoenix avatar digital-phoenix commented on June 16, 2024 1

@jovialcore I'm still working on this and it is in the final test phase.

from refact-lsp.

olegklimov avatar olegklimov commented on June 16, 2024

Some tricky parts as in #1 :

  • Showing gray text and completion popup might conflict, the popup has its strengths too. So the decision about which suggestion to show might be tricky, sure it's shouldn't show both at the same time.

  • Grey text should not increase visible line counters, for example a code suggestion at line 100 that has 5 lines shouldn't make the next line 106 before it's accepted.

from refact-lsp.

olegklimov avatar olegklimov commented on June 16, 2024

/bounty $1000

from refact-lsp.

algora-pbc avatar algora-pbc commented on June 16, 2024

💎 $1,000 bounty created by olegklimov
🙋 If you'd like to work on this issue, comment below to get assigned
👉 To claim this bounty, submit a pull request that includes the text /claim #2 somewhere in its body
📝 Before proceeding, please make sure you can receive payouts in your country
💵 Payment arrives in your account 2-5 days after the bounty is rewarded
💯 You keep 100% of the bounty award
🙏 Thank you for contributing to smallcloudai/refact-lsp!

from refact-lsp.

olegklimov avatar olegklimov commented on June 16, 2024

You can read about it there:

https://en.wikipedia.org/wiki/Visual_Studio
https://en.wikipedia.org/wiki/Visual_Studio_Code

from refact-lsp.

digital-phoenix avatar digital-phoenix commented on June 16, 2024

/attempt #2

I'll give this issue a shot

Options

from refact-lsp.

algora-pbc avatar algora-pbc commented on June 16, 2024

Note: The user @haruncurak is already attempting to complete issue #2 and claim the bounty. If you attempt to complete the same issue, there is a chance that @haruncurak will complete the issue first, and be awarded the bounty. We recommend discussing with @haruncurak and potentially collaborating on the same solution versus creating an alternate solution.

from refact-lsp.

olegklimov avatar olegklimov commented on June 16, 2024

@digital-phoenix nice!

from refact-lsp.

ogil7190 avatar ogil7190 commented on June 16, 2024

@olegklimov is there anything pending on vs code side or is this complete, can you explain this as well if possible.?

from refact-lsp.

olegklimov avatar olegklimov commented on June 16, 2024

No it's still open. I didn't see an ongoing effort either.

from refact-lsp.

digital-phoenix avatar digital-phoenix commented on June 16, 2024

I should be finished this fairly soon. The biggest issue is that there is very limited documentation around the features needed to implement multiline text without adding it to the file. But I believe I've found everything I need at this point.

from refact-lsp.

digital-phoenix avatar digital-phoenix commented on June 16, 2024
initalTestResults

from refact-lsp.

digital-phoenix avatar digital-phoenix commented on June 16, 2024

This is starting to come together

from refact-lsp.

olegklimov avatar olegklimov commented on June 16, 2024

Oh wow! How many DLLs did you have to link? )

from refact-lsp.

digital-phoenix avatar digital-phoenix commented on June 16, 2024

The extension only required some standard DLLs. Which include: several System.* DLLs; the Visual studio SDK and it's dependencies; and the Microsoft Presentation Framework for UI rendering.

from refact-lsp.

digital-phoenix avatar digital-phoenix commented on June 16, 2024

VisualStudioDemo

from refact-lsp.

olegklimov avatar olegklimov commented on June 16, 2024

Here I have a random link:

https://github.com/jasonlyu123/SvelteVisualStudio

Ultimately we want this completion to work with our LSP server (not a part of this issue). There should be some good way to run it.

from refact-lsp.

digital-phoenix avatar digital-phoenix commented on June 16, 2024

I created a new repo with the source code here:
https://github.com/digital-phoenix/MultilineGreyText/tree/main/MultilineGreyText

from refact-lsp.

digital-phoenix avatar digital-phoenix commented on June 16, 2024

@olegklimov I believe the code I posted should resolve this issue. Let me know if you have any further questions.

I sent you a message on the issue for Sublime Lsp with my email so you can add me to the slack. Once you add me to the slack we can talk about the steps required to implement a full Lsp plugin in Visual Studio.

from refact-lsp.

olegklimov avatar olegklimov commented on June 16, 2024

Fantastic! I'll take a look on Monday.

from refact-lsp.

olegklimov avatar olegklimov commented on June 16, 2024

OK it's Wednesday, but I finally got to it.

image

Here's what I'm getting, trying to open MultilineGreyText solution. I'm using Visual Studio for Mac.

from refact-lsp.

olegklimov avatar olegklimov commented on June 16, 2024

I found this guide from 2017

https://learn.microsoft.com/en-us/previous-versions/visualstudio/mac/extending-visual-studio-mac-walkthrough?view=vsmac-2017

But I couldn't follow it on my computer.

I found the guid VS was complaining about on the screenshot above:

https://gist.github.com/vnl/4b1851bfbc923cd3ac0e98aa8d8b2eef

I deleted the line with this guis from MultilineGreyText.csproj, and I got this far:

image

If I right-click on "Packages" I can make this happen:

  GET https://api.nuget.org/v3/registration5-gz-semver2/microsoft.visualstudio.sdk/index.json
  OK https://api.nuget.org/v3/registration5-gz-semver2/microsoft.visualstudio.sdk/index.json 212ms
Getting restore information for project ~/Projects/MultilineGreyText/MultilineGreyText/MultilineGreyText.csproj
~/Projects/MultilineGreyText/MultilineGreyText/MultilineGreyText.csproj(76,3) : error MSB4019: The imported project "/usr/local/share/dotnet/sdk/7.0.308/Microsoft/VisualStudio/v17.0/VSSDK/Microsoft.VsSDK.targets" was not found. Confirm that the expression in the Import declaration "/usr/local/share/dotnet/sdk/7.0.308/Microsoft/VisualStudio/v17.0/VSSDK/Microsoft.VsSDK.targets" is correct, and that the file exists on disk.
Unable to create package spec for project. '~/Projects/MultilineGreyText/MultilineGreyText/MultilineGreyText.csproj'

I feeling it's harder than it should be. Maybe I'm doing something wrong.

from refact-lsp.

digital-phoenix avatar digital-phoenix commented on June 16, 2024

@olegklimov It sounds like Microsoft is ending support for Visual Studio classic on mac https://devblogs.microsoft.com/visualstudio/visual-studio-for-mac-retirement-announcement/ . As extension support for Visual Studio mac appears to be very limited. Would it be possible to test this extension on Windows or a virtual machine running Windows?

from refact-lsp.

olegklimov avatar olegklimov commented on June 16, 2024

extension support for Visual Studio mac appears to be very limited

Is that what it is?

🤔 I'll have access to a windows machine next week. I'll try to find someone to test the code before that.

from refact-lsp.

digital-phoenix avatar digital-phoenix commented on June 16, 2024

@olegklimov yeah visual studio for mac extensions appear to be supported primarily through Monodevelop libraries. I'd basically need to create an entirely separate extension to get the extension to work on Mac.

from refact-lsp.

jovialcore avatar jovialcore commented on June 16, 2024

Hi, anyone still working on this ?

from refact-lsp.

olegklimov avatar olegklimov commented on June 16, 2024

I tested @digital-phoenix 's code, it's actually pretty good! (as a hello world example)

from refact-lsp.

digital-phoenix avatar digital-phoenix commented on June 16, 2024

@olegklimov is there anything left to do for this issue or is it resolved?

from refact-lsp.

olegklimov avatar olegklimov commented on June 16, 2024

Hey @digital-phoenix I think you need to type "/claim" for workflow to go through

from refact-lsp.

digital-phoenix avatar digital-phoenix commented on June 16, 2024

/claim #2

from refact-lsp.

olegklimov avatar olegklimov commented on June 16, 2024

/tip $1000 @digital-phoenix

from refact-lsp.

algora-pbc avatar algora-pbc commented on June 16, 2024

👉 @olegklimov: Click here to proceed

from refact-lsp.

algora-pbc avatar algora-pbc commented on June 16, 2024

🎉🎈 @digital-phoenix has been awarded $1,000! 🎈🎊

from refact-lsp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.