Comments (34)
I think I have implemented all the requirements for this issue.
I will post the code soon.
Let me know if you have any questions.
from refact-lsp.
@jovialcore I'm still working on this and it is in the final test phase.
from refact-lsp.
Some tricky parts as in #1 :
-
Showing gray text and completion popup might conflict, the popup has its strengths too. So the decision about which suggestion to show might be tricky, sure it's shouldn't show both at the same time.
-
Grey text should not increase visible line counters, for example a code suggestion at line 100 that has 5 lines shouldn't make the next line 106 before it's accepted.
from refact-lsp.
/bounty $1000
from refact-lsp.
💎 $1,000 bounty created by olegklimov
🙋 If you'd like to work on this issue, comment below to get assigned
👉 To claim this bounty, submit a pull request that includes the text /claim #2
somewhere in its body
📝 Before proceeding, please make sure you can receive payouts in your country
💵 Payment arrives in your account 2-5 days after the bounty is rewarded
💯 You keep 100% of the bounty award
🙏 Thank you for contributing to smallcloudai/refact-lsp!
from refact-lsp.
You can read about it there:
https://en.wikipedia.org/wiki/Visual_Studio
https://en.wikipedia.org/wiki/Visual_Studio_Code
from refact-lsp.
/attempt #2
I'll give this issue a shot
Options
from refact-lsp.
Note: The user @haruncurak is already attempting to complete issue #2 and claim the bounty. If you attempt to complete the same issue, there is a chance that @haruncurak will complete the issue first, and be awarded the bounty. We recommend discussing with @haruncurak and potentially collaborating on the same solution versus creating an alternate solution.
from refact-lsp.
@digital-phoenix nice!
from refact-lsp.
@olegklimov is there anything pending on vs code side or is this complete, can you explain this as well if possible.?
from refact-lsp.
No it's still open. I didn't see an ongoing effort either.
from refact-lsp.
I should be finished this fairly soon. The biggest issue is that there is very limited documentation around the features needed to implement multiline text without adding it to the file. But I believe I've found everything I need at this point.
from refact-lsp.
![initalTestResults](https://private-user-images.githubusercontent.com/350208/271126583-77b364cc-55cf-47e4-96a3-6477d4f580b7.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTg1MDg1NzUsIm5iZiI6MTcxODUwODI3NSwicGF0aCI6Ii8zNTAyMDgvMjcxMTI2NTgzLTc3YjM2NGNjLTU1Y2YtNDdlNC05NmEzLTY0NzdkNGY1ODBiNy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNjE2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDYxNlQwMzI0MzVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1lZDVjYTI5M2E3M2UwN2U2YTEyZjg0YjYzZWU5NWExOGM0ODBjMzI2YTc0YmY1OTFiYjMxMTNiYWQ3MzcxOWMwJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.VxX-3ZD1914Gef9BhX0d9UaWFBQmw9z9msLCamJK95I)
from refact-lsp.
This is starting to come together
from refact-lsp.
Oh wow! How many DLLs did you have to link? )
from refact-lsp.
The extension only required some standard DLLs. Which include: several System.* DLLs; the Visual studio SDK and it's dependencies; and the Microsoft Presentation Framework for UI rendering.
from refact-lsp.
from refact-lsp.
Here I have a random link:
https://github.com/jasonlyu123/SvelteVisualStudio
Ultimately we want this completion to work with our LSP server (not a part of this issue). There should be some good way to run it.
from refact-lsp.
I created a new repo with the source code here:
https://github.com/digital-phoenix/MultilineGreyText/tree/main/MultilineGreyText
from refact-lsp.
@olegklimov I believe the code I posted should resolve this issue. Let me know if you have any further questions.
I sent you a message on the issue for Sublime Lsp with my email so you can add me to the slack. Once you add me to the slack we can talk about the steps required to implement a full Lsp plugin in Visual Studio.
from refact-lsp.
Fantastic! I'll take a look on Monday.
from refact-lsp.
OK it's Wednesday, but I finally got to it.
![image](https://private-user-images.githubusercontent.com/18546213/272505109-24271d14-a525-41a4-a138-c05a080f5372.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTg1MDg1NzUsIm5iZiI6MTcxODUwODI3NSwicGF0aCI6Ii8xODU0NjIxMy8yNzI1MDUxMDktMjQyNzFkMTQtYTUyNS00MWE0LWExMzgtYzA1YTA4MGY1MzcyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjE2VDAzMjQzNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTM3MGY5Yjc2NDg3NjI4MWIwMTVlOTU4NmFkY2I4NjNiMGFiODY1M2NmYTFlODY1M2JhNDIwZjNjZWJkZWY4NzEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.cv3iYhZp2m7IcsklWi8bFEs8LXTeeos7pel8PM4qYZM)
Here's what I'm getting, trying to open MultilineGreyText solution. I'm using Visual Studio for Mac.
from refact-lsp.
I found this guide from 2017
But I couldn't follow it on my computer.
I found the guid VS was complaining about on the screenshot above:
https://gist.github.com/vnl/4b1851bfbc923cd3ac0e98aa8d8b2eef
I deleted the line with this guis from MultilineGreyText.csproj
, and I got this far:
![image](https://private-user-images.githubusercontent.com/18546213/272509166-84780b4a-6e54-411a-9681-6bd8dadca2d6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTg1MDg1NzUsIm5iZiI6MTcxODUwODI3NSwicGF0aCI6Ii8xODU0NjIxMy8yNzI1MDkxNjYtODQ3ODBiNGEtNmU1NC00MTFhLTk2ODEtNmJkOGRhZGNhMmQ2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjE2VDAzMjQzNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPThkZjVjNmViOGNkN2IyMDA0NmNhNzJlMzJmMmUyYTE2ZWUzNTc1YjkwMTNhNDEyNTQ3MzRkZDg4ZjVhZWRiNGMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.PEvWCnA3zujLFi7kigMZMcQN8x3UUT-bFEX7Qk1P440)
If I right-click on "Packages" I can make this happen:
GET https://api.nuget.org/v3/registration5-gz-semver2/microsoft.visualstudio.sdk/index.json
OK https://api.nuget.org/v3/registration5-gz-semver2/microsoft.visualstudio.sdk/index.json 212ms
Getting restore information for project ~/Projects/MultilineGreyText/MultilineGreyText/MultilineGreyText.csproj
~/Projects/MultilineGreyText/MultilineGreyText/MultilineGreyText.csproj(76,3) : error MSB4019: The imported project "/usr/local/share/dotnet/sdk/7.0.308/Microsoft/VisualStudio/v17.0/VSSDK/Microsoft.VsSDK.targets" was not found. Confirm that the expression in the Import declaration "/usr/local/share/dotnet/sdk/7.0.308/Microsoft/VisualStudio/v17.0/VSSDK/Microsoft.VsSDK.targets" is correct, and that the file exists on disk.
Unable to create package spec for project. '~/Projects/MultilineGreyText/MultilineGreyText/MultilineGreyText.csproj'
I feeling it's harder than it should be. Maybe I'm doing something wrong.
from refact-lsp.
@olegklimov It sounds like Microsoft is ending support for Visual Studio classic on mac https://devblogs.microsoft.com/visualstudio/visual-studio-for-mac-retirement-announcement/ . As extension support for Visual Studio mac appears to be very limited. Would it be possible to test this extension on Windows or a virtual machine running Windows?
from refact-lsp.
extension support for Visual Studio mac appears to be very limited
Is that what it is?
🤔 I'll have access to a windows machine next week. I'll try to find someone to test the code before that.
from refact-lsp.
@olegklimov yeah visual studio for mac extensions appear to be supported primarily through Monodevelop libraries. I'd basically need to create an entirely separate extension to get the extension to work on Mac.
from refact-lsp.
Hi, anyone still working on this ?
from refact-lsp.
I tested @digital-phoenix 's code, it's actually pretty good! (as a hello world example)
from refact-lsp.
@olegklimov is there anything left to do for this issue or is it resolved?
from refact-lsp.
Hey @digital-phoenix I think you need to type "/claim" for workflow to go through
from refact-lsp.
/claim #2
from refact-lsp.
/tip $1000 @digital-phoenix
from refact-lsp.
👉 @olegklimov: Click here to proceed
from refact-lsp.
🎉🎈 @digital-phoenix has been awarded $1,000! 🎈🎊
from refact-lsp.
Related Issues (20)
- [rust] Insert RAG results into scratchpads better
- [rust] add exception handling in lsp thread
- build failed HOT 1
- [rust] Tokenizer loading
- [rust] Panic when use file in completion with some Chinese symbols
- Pull unsaved file in RAG (still doesn't work!) HOT 1
- @file should produce smooth ramp, not 20-line blocks HOT 1
- Cannot get tokenizer for Claude models HOT 2
- neovim?
- [RAG] Filter-out machine-generated files HOT 1
- @file makes refact-lsp panic HOT 1
- duplicated results in at-completion HOT 2
- Hide system at-commands from users? HOT 1
- error when attaching a file -- overflow HOT 1
- vecdb indexing shouldn't have cooldown when IDE connects to it and sends files list
- inconsistency within at-preview results and execute HOT 1
- add to telemetry that user uses RAG for completion HOT 1
- Build failed: error[E0635]: unknown feature `stdsimd` HOT 1
- Context Size for RAG in Chat HOT 1
- LoRA
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from refact-lsp.