Giter Site home page Giter Site logo

Comments (4)

n1hility avatar n1hility commented on August 27, 2024

For the moment you can add java 8 test classes here: https://github.com/wildfly/typeannotation-test

It has come time to move to 8, but this will probably mean declaring a 3.0 version.

from jandex.

vlsi avatar vlsi commented on August 27, 2024

For the moment you can add java 8 test classes here: https://github.com/wildfly/typeannotation-test

It feels weird to add classes in one place and debug them in another :-/
That would be super-weird for PR purposes as well.


I guess different modules can have different source/target versions if you still need to support Java 6/7.
Have you explored that possibility?

However, jandex issues hit Apache Calcite badly, and I guess it might be even easier to fix jandex than implement workarounds in Calcite :-/

On the other hand, I have no preference regarding 6-7-8 (Calcite is Java 8+ anyway), so if you migrate jandex to Java8, then it would indeed help with testing.

from jandex.

n1hility avatar n1hility commented on August 27, 2024

For the moment you can add java 8 test classes here: https://github.com/wildfly/typeannotation-test

It feels weird to add classes in one place and debug them in another :-/
That would be super-weird for PR purposes as well.

The test cases you debug are only expected to be in the main jadex project, it's just the input byteocde that is elsewhere,. The pattern is like this since the project is forward bytecode compatible (it can read newer bytecode than the JVM it runs on. E.g you can read Java 11 bytecode running on a Java 6 JVM). I agree its unusual, and means you have to build install in two separate steps.
.

I guess different modules can have different source/target versions if you still need to support Java 6/7.
Have you explored that possibility?

Historically, the only reason was to avoid requiring contributors to have extra ultra new JVMs around. So for example if we added early support for a pre-release of say Java 15, but you just wanted to fix something for the current stable VMs its a bit of a PITA.

However, jandex issues hit Apache Calcite badly, and I guess it might be even easier to fix jandex than implement workarounds in Calcite :-/

sorry about that!

On the other hand, I have no preference regarding 6-7-8 (Calcite is Java 8+ anyway), so if you migrate jandex to Java8, then it would indeed help with testing.

Yeah I think its a bit overdue to move to 8 as a minimum baseline. I'd be ok with exploring a multi-module interim step for at least bytecode through 11

from jandex.

Ladicek avatar Ladicek commented on August 27, 2024

This is now done on the smallrye branch.

from jandex.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.