Comments (4)
For the moment you can add java 8 test classes here: https://github.com/wildfly/typeannotation-test
It has come time to move to 8, but this will probably mean declaring a 3.0 version.
from jandex.
For the moment you can add java 8 test classes here: https://github.com/wildfly/typeannotation-test
It feels weird to add classes in one place and debug them in another :-/
That would be super-weird for PR purposes as well.
I guess different modules can have different source/target versions if you still need to support Java 6/7.
Have you explored that possibility?
However, jandex issues hit Apache Calcite badly, and I guess it might be even easier to fix jandex than implement workarounds in Calcite :-/
On the other hand, I have no preference regarding 6-7-8 (Calcite is Java 8+ anyway), so if you migrate jandex to Java8, then it would indeed help with testing.
from jandex.
For the moment you can add java 8 test classes here: https://github.com/wildfly/typeannotation-test
It feels weird to add classes in one place and debug them in another :-/
That would be super-weird for PR purposes as well.
The test cases you debug are only expected to be in the main jadex project, it's just the input byteocde that is elsewhere,. The pattern is like this since the project is forward bytecode compatible (it can read newer bytecode than the JVM it runs on. E.g you can read Java 11 bytecode running on a Java 6 JVM). I agree its unusual, and means you have to build install in two separate steps.
.
I guess different modules can have different source/target versions if you still need to support Java 6/7.
Have you explored that possibility?
Historically, the only reason was to avoid requiring contributors to have extra ultra new JVMs around. So for example if we added early support for a pre-release of say Java 15, but you just wanted to fix something for the current stable VMs its a bit of a PITA.
However, jandex issues hit Apache Calcite badly, and I guess it might be even easier to fix jandex than implement workarounds in Calcite :-/
sorry about that!
On the other hand, I have no preference regarding 6-7-8 (Calcite is Java 8+ anyway), so if you migrate jandex to Java8, then it would indeed help with testing.
Yeah I think its a bit overdue to move to 8 as a minimum baseline. I'd be ok with exploring a multi-module interim step for at least bytecode through 11
from jandex.
This is now done on the smallrye
branch.
from jandex.
Related Issues (20)
- `Not a class` error for generated constructor in nested class when using ECJ (and lombok) HOT 12
- NegativeArraySizeException while scanning groovy-3.0.13.jar HOT 1
- Jandex fails when indexing a Kotlin-generated class with certain type annotation HOT 2
- jandex-maven-plugin throws IllegalArgumentException: Comparison method violates its general contract HOT 8
- jandex does not build with Maven 3.9.0 HOT 2
- java.lang.ClassCastException HOT 12
- org.jboss.jandex.UnsupportedVersion: Version: 11 HOT 2
- Error when running on Java 21-ea HOT 11
- classloader.getResource(entryName) return null HOT 1
- Add good first issues and codeowners file HOT 1
- Indexing takes over 100x longer on big file HOT 15
- Migrating from Jandex maven plugin 1.1.1 to 3.1.3 fails to create intermediate directories when generating an index HOT 2
- Maven plugin error with 21-graalce HOT 3
- Indexing throws an NPE in some cases HOT 4
- Backport the fix for #310 to 2.4.x: Error with Java 21: `Cannot read the array length because "bytes" is null` HOT 2
- Comparison method violates its general contract! HOT 18
- Skip Plugin Execution on packaging type pom HOT 1
- CODEOWNERS contains errors HOT 1
- Add ClassInfo.method(String, List<Type>) HOT 2
- Published maven-metadata.xml delisted 3.1.6 and newer from version list HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jandex.