Comments (1)
Please ensure that this proposed feature set is not too tailored towards Smarkets requirements and does consider the open-source community. A few initial thoughts come to mind:
- Enabling gitOps and audit reporting should be flags, as not everyone may want to use this functionality.
- It seems you are proposing these CI pipelines for adding versioning tags, what is the thought process for adding this requirement?
- While tagging is useful for releasing and tracking versions of release changes, there may be certain parts of a codebase / particular repo's that you do not want to enable this feature for - e.g. if I am not building or pushing artefacts in the change.
- Surely it makes more sense to tag when releases are made/cut rather than on every commit?
- Marge should have the possibility to be compatible with a variety of CD tools and not just be restricted to ArgoCD.
- CD is a difficult challenge and everyone implements this process differently - when do we autodeploy vs click-on-demand deploy etc. This probably is something that should be decoupled from Marge. Her primary focus surrounds CI, and unless there are plans to cater for all the different forms of CD / CD tools, adding this will muddy the water.
-
Component asset registrar or a centralised ops portal with notifications.
- Adding git commits / details to the git log is a more flexible solution in that there is no dependency on external tools.
- Like with CD if a choice is made to use an asset register, this should have the extensibility to support any other asset registries the community would like to use.
- Notifications seem more like a CD requirement? What would be the requirement for centralised notifications for merged changes?
- How are features 1/2/3 useful to me if I am not dealing with containerisation?
- How does this workflow affect the run time of Marge? We still need to make sure changes can be merged at a reasonable rate, especially if urgent changes are being made.
- A drastic breakdown to put my concern across, but: as you increase the Marge feature set, you're also increasing the final CI runtime, and the backlog of changes to be merged, and increasing the chances of batching (if enabled), this increases the chance of infinite batching, increasing the possibility of Marge being stuck in a sad loop of not merging anything 😁
- A valid point is raised in the PR linked to the linked ticket -
jenkins retry
should be removed in favour of callingmerge_request_pipeline_trigger.
from marge-bot.
Related Issues (20)
- Marge-bot logs "Someone skipped the queue! Will have to try again..." even though she merged an MR
- Guarantee final pipeline when assigned to marge-bot
- Bot cannot receive pipeline status with no-ff-merge HOT 10
- feature request: rebase without pushing
- Feature request: let marge bot leave a comment when she notices that an MR was assigned to her
- SSO User Support
- Bug: `--guarantee-final-pipeline` does not work with Gitlab CI
- "Branch cannot be merged" still happening HOT 1
- Source branches are not deleted when using batch mode HOT 4
- LetsEncrypt cert from the included CA Bundle is expired
- Marge Bot is logging PAT while fetching the repository
- Document group access tokens HOT 2
- Marge uses SSH even if I configure it to use HTTPS
- Marge ignores /etc/hosts
- Hard-to-interpret messages when discussions are unresolved
- Feature Request: Configure who to assign if merge doesn't work HOT 1
- Marge-bot container keeps restarting
- Fix merging action when last source commit is not last target commit (gitlab_rebase) HOT 1
- Wait for CI to pass checks happen too fast for Jenkins plugin HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from marge-bot.