Giter Site home page Giter Site logo

Comments (4)

albertoabellagarcia avatar albertoabellagarcia commented on June 21, 2024

I am afraid that you did not notice of the line
"$ref": "https://smart-data-models.github.io/dataModel.Device/device-schema.json#/definitions/Device-Commons"
where these properties remained untouched.
what is true is that they were missing the description from the shared device schema and consequently they did not appear in the spec.
We have already documented them, and when we launch the updating of the specs it will be corrected.
So thank you for noticing that. the spec will be updated soon to reflect them.

from datamodel.device.

albertoabellagarcia avatar albertoabellagarcia commented on June 21, 2024

updated specification

from datamodel.device.

michzimny avatar michzimny commented on June 21, 2024

Thank you. My point was about https://github.com/smart-data-models/dataModel.Device/blob/master/Device/doc/spec.md. Sorry for not being clear enough.

However, there are still some problems with category, so I think this issue should be reopened:

  1. In DeviceModel/doc/spec.md, category is not defined.
  2. In Device/doc/spec.md, category is bad formatted.

Re 1:
It was well described before the changes in December:

  • category : Device's category(ies).
    - Attribute type: Property. List of Text
    - Allowed values, one of the following or any other meaningful to the
    application:
    - sensor : A device that detects and responds to events or changes in
    the physical environment such as light, motion, or temperature changes.
    https://w3id.org/saref#Sensor.
    - actuator : A device responsible for moving or controlling a mechanism
    or system. https://w3id.org/saref#Actuator.
    - (...)

Re2 :

The current state:

  • category: A device that detects and responds to events or changes in the physical environment such as light, motion, or temperature changes. https://w3id.org/saref#Sensor. actuator : A device responsible for moving or controlling a mechanism or system. https://w3id.org/saref#Actuator. Meter : A device built to accurately detect and display a quantity in a form readable by a human being. Partially defined by SAREF. HVAC : Heating, Ventilation and Air Conditioning (HVAC) device that provides indoor environmental comfort. https://w3id.org/saref#HVAC. Network : A device used to connect other devices in a network, such as hub, switch or router in a LAN or Sensor network. (https://w3id.org/saref#Network.Multimedia : A device designed to display, store, record or play multimedia content such as audio, images, animation, video. Enum:'actuator, beacon, endgun, HVAC, implement, irrSection, irrSystem, meter, multimedia, network, sensor'

For instance, it is not clear what is the first part about ("A device that detects..."). Perhaps, word "sensor" is missing in the beginning. Attribute type is missing. It says 'Meter', but the correct value is 'meter'. A parenthesis is open but not closed. etc.

from datamodel.device.

michzimny avatar michzimny commented on June 21, 2024

Forgive me but the problem is that we were referring to this documentation in our project, and since those changes, it's harder to read and to understand by newcomers.

from datamodel.device.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.