Giter Site home page Giter Site logo

Comments (4)

SmileyChris avatar SmileyChris commented on July 19, 2024

Yeah, it's probably not the smartest of my ideas :P

In fact, I'm not really sold on the whole pickle-hash idea, since it seems that the django-storages s3 backend can't handle being pickled anyway. My reasoning is that if you were using a storage backend which has initialisable arguments as part of the class, you want to be able to differentiate between two unique versions of those storage classes.

But that's me rambling. I think I'll get around to just try/excepting the pickle and putting a hash of the full class path if pickling fails.

Back on topic, if you want to refactor the code to use a separate model for the storage then I'd be happy to pull it in. You'll need to make sure that the current storage hash lookup is cached - don't need another database hit...

from easy-thumbnails.

SmileyChris avatar SmileyChris commented on July 19, 2024

Done (haven't pushed a new version to pypi yet, but it's in the repo)

from easy-thumbnails.

SmileyChris avatar SmileyChris commented on July 19, 2024

(I've actually pushed this to a branch for now... i'm not quite happy with the migrations)

from easy-thumbnails.

SmileyChris avatar SmileyChris commented on July 19, 2024

(ok, i'm happy enough now, merged to master and deleted branch)

from easy-thumbnails.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.