Comments (7)
Definitely sounds wrong... would like some more detail so I can figure out exactly where the problem lies.
Could you please provide the following info:
- the exact output you are getting for one incorrect thumbnail
- the raw value of the stored field
from easy-thumbnails.
in files.py Thumbnailer::get_thumbnail_name ends with the line:
return os.path.join(basedir, path, subdir, filename)
On windows this will join with the '' character. I think it should be:
return os.path.join(basedir, path, subdir, filename).replace('', '/')
The raw values are all stored with the correct forward slash (/).
from easy-thumbnails.
yep, seems right. Simpler version would just be '/'.join(bits) :)
from easy-thumbnails.
os.path.join is smart enough to know what to do with empty directories though. '/'.join is too naive and you can get things like basedir//subdir/filename instead of basedir/subdir/filename.
from easy-thumbnails.
Right, in fact looking closer, I'm not actually convinced that we need to do this.
ThumbnailFile uses the same logic as a FieldFile for url generation, which involves using the storage's url
method. This method does the replacement.
How are you generating the url?
from easy-thumbnails.
You are correct I was doing it the sorl-thumbnail way, which was wrong.
{% thumbnail model.image 50x50 as image %}
Then I was using {{image}} instead of {{image.url}}
from easy-thumbnails.
Yeah, I upgraded a site recently and was bit with that. Glad we got to the bottom of it!
If you want to write some sorl-thumbnail upgrade docs, that'd be cool ;)
from easy-thumbnails.
Related Issues (20)
- Template fails to render due to ZeroDivisionError when input is corrupted
- ContentFile without a name breaks easy_thumbnails
- ANTIALIAS is deprecated and will be removed in Pillow 10
- svglib dependency is missing HOT 9
- Imoprt error
- Django 4.1 template tag 'thumbnail' conflict with sorl-thumbnails
- Saving TIFF image raises Value error HOT 2
- How to force a single field to convert the thumbails to JPG even if PNG with alpha was provided
- DeprecationWarning from get_storage_class HOT 1
- Lots of duplicated queries HOT 1
- Support for pillow >= 10.0.0.0 HOT 1
- SVG File.width - This backend doesn't support absolute paths. HOT 2
- ZeroDivisionError when thumbnail is passed a 0x0 SVG HOT 1
- Increase File name field length HOT 1
- Allow use of new Django4.2 STORAGE config
- animated gifs - preserve animation, as PIL/Pillow supports it HOT 3
- up to date docs?
- Data too long on serving thumbnails
- DeprecationWarning: 'imghdr' is deprecated and slated for removal in Python 3.13 HOT 1
- Django 4.2.14 (and 5.0.7) fixes of CVE-2024-39330 break thumbnail generation when optimisations is used HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from easy-thumbnails.