Giter Site home page Giter Site logo

Comments (7)

smirik avatar smirik commented on June 18, 2024

Hi Richard!

Thank you for the note. Would you like to apply these changes via Pull Request workflow? It will be the easiest way how to handle that?

Here is the instruction for them: https://help.github.com/articles/creating-a-pull-request/

from mercury.

texadactyl avatar texadactyl commented on June 18, 2024

Done. Thank you. Sent you an email.

from mercury.

texadactyl avatar texadactyl commented on June 18, 2024

I just noticed that the number of pull requests = 0. Maybe I screwed up?

from mercury.

smirik avatar smirik commented on June 18, 2024

Yeah, still 0. You need to pull down the code (via fork), apply the changes & then send PR.

from mercury.

texadactyl avatar texadactyl commented on June 18, 2024

I actually had done that and somehow (?) mysteriously backed out of the Pull Request. It's a bit of a confusing process, coming from a forked repo. Anyhow, 2nd time's a charm.

from mercury.

smirik avatar smirik commented on June 18, 2024

Looks good. Let me & @idovgalyov test the changes & then we can merge it.

from mercury.

smirik avatar smirik commented on June 18, 2024

Merged in #11.

from mercury.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.