Giter Site home page Giter Site logo

Comments (4)

elinorbgr avatar elinorbgr commented on May 25, 2024

I think we should be able to add a set_modes(&self, &[Mode]) method directly, replacing the previous contents list.

Though, what is a realistic explanation for an output changing its supported modes ?

We should take into account the fact that the wayland protocol does not support advertising that a mode is no longer supported, so a radical change of supported modes is probably better reflected a the suppression of the output and the creation of a new one...

from smithay.

Drakulix avatar Drakulix commented on May 25, 2024

There are two cases for this:

  1. Nested backends that may use almost every value as a Mode.
  2. Mirroring outputs, which should only expose modes supported by both monitors.

For case one this would mean re-creating wl_output for every change in size of the compositor window, no idea what is the best practice here.

For the second case it might be better to just re-create the output, but technically the output being rendered to is still the same just with some new constraints given by the added mirror. Although one could argue, that the combination of two outputs results in a new output. I really have no idea what the best practice is here and how weston or gnome for example do handle this.

from smithay.

elinorbgr avatar elinorbgr commented on May 25, 2024

Not sure what would be the best choice...

For context, Weston's drawing area is not resized when started as an X client and its window size changes. Causing black borders or part of the wayland screen being cut.

from smithay.

Drakulix avatar Drakulix commented on May 25, 2024

I will try to figure out what gnome does on multi-monitor setups. I find weston's "solution" to the problem rather ugly. I guess we will end up just recreating the output in either case.

from smithay.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.