Giter Site home page Giter Site logo

Comments (4)

ianbotsf avatar ianbotsf commented on August 12, 2024

@monosoul thanks for opening this feature request, Micrometer looks cool. We can't prioritize this just yet but we'll leave it open so others can 👍+1 it.

I see you've made some contributions to the Micrometer GH repository so you've clearly got some familiarity...if you'd like to contribute a pull request to enable this feature, please feel free!

The telemetry interfaces/implementations live in smithy-kotlin not aws-sdk-kotlin so I'll be closing the other issue you opened in favor of this one.

from smithy-kotlin.

monosoul avatar monosoul commented on August 12, 2024

Hey @ianbotsf , I took a quick look at the API you have for telemetry providers and it seems like interfaces there are heavily influenced by OTel implementation. Not yet sure if I'll be able to introduce micrometer implementation without touching some of those interfaces, therefore I was hoping someone more familiar with the code base will take a look into that 😅
I might give it a try too tho 🤔

from smithy-kotlin.

ianbotsf avatar ianbotsf commented on August 12, 2024

Yes, those interfaces in telemetry-api are pretty much fixed and won't likely be changed. New implementations will have to conform themselves to those interfaces, ignoring the features they can't support, using extra configuration options/extensions to support features not modeled in the telemetry API, etc.

If you're an existing user of both the AWS SDK for Kotlin and Micrometer then you're likely in the best position to at least start on an implementation—even one that's narrowly tailored to your specific use case. If it's generalizable enough then a PR might be warranted. Feel free to reach out with questions about the existing interfaces and the current implementation for OTel.

from smithy-kotlin.

monosoul avatar monosoul commented on August 12, 2024

Okay, I hacked for a bit and this might work I think: #1089

from smithy-kotlin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.