Comments (4)
@monosoul thanks for opening this feature request, Micrometer looks cool. We can't prioritize this just yet but we'll leave it open so others can 👍+1 it.
I see you've made some contributions to the Micrometer GH repository so you've clearly got some familiarity...if you'd like to contribute a pull request to enable this feature, please feel free!
The telemetry interfaces/implementations live in smithy-kotlin not aws-sdk-kotlin so I'll be closing the other issue you opened in favor of this one.
from smithy-kotlin.
Hey @ianbotsf , I took a quick look at the API you have for telemetry providers and it seems like interfaces there are heavily influenced by OTel implementation. Not yet sure if I'll be able to introduce micrometer implementation without touching some of those interfaces, therefore I was hoping someone more familiar with the code base will take a look into that 😅
I might give it a try too tho 🤔
from smithy-kotlin.
Yes, those interfaces in telemetry-api are pretty much fixed and won't likely be changed. New implementations will have to conform themselves to those interfaces, ignoring the features they can't support, using extra configuration options/extensions to support features not modeled in the telemetry API, etc.
If you're an existing user of both the AWS SDK for Kotlin and Micrometer then you're likely in the best position to at least start on an implementation—even one that's narrowly tailored to your specific use case. If it's generalizable enough then a PR might be warranted. Feel free to reach out with questions about the existing interfaces and the current implementation for OTel.
from smithy-kotlin.
Okay, I hacked for a bit and this might work I think: #1089
from smithy-kotlin.
Related Issues (20)
- OkHttp: Retry on SocketException: Broken pipe HOT 7
- Invalid signatures due to URL encoding changes (0.36.1-beta vs 1.0.0+) HOT 7
- Generic service-stub codegen
- Url.parse(url: String) strips @ in scenarios it shouldn't
- Signing issue when pre-computed hash provided in x-amz-content-sha256
- Union members targeting smithy.api#Unit generates extraneous structures HOT 1
- Document/disable OkHttp's automatic response decompression HOT 2
- Map shapes targeting enum keys are generated as kotlin.String HOT 1
- Support for Java interop HOT 2
- IllegalStateException "Unbalanced enter/exit" in okio AsyncTimeout
- Smithy is not compatible with OkHttp 5.0.0-alpha.14 HOT 1
- Incorrect "http.nonProxyHosts" property name HOT 1
- https.nonProxyHosts does not handle * wildcard HOT 1
- Check for empty proxy hosts HOT 2
- XML protocols don't generate list deserializers properly for old-style enum elements
- Deserializer for union member `Map<*, List<Enum>>` generates incorrectly
- Unions with member names matching auto-imported Kotlin symbols fail to codegen correctly
- Idempotency tokens should be ignored when applied to a nested shape
- Codegen doesn't properly handle unions with a member that has the same name as the union
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from smithy-kotlin.