Giter Site home page Giter Site logo

Expanding peakrange in fillpeaks about xcms HOT 6 CLOSED

sneumann avatar sneumann commented on June 18, 2024
Expanding peakrange in fillpeaks

from xcms.

Comments (6)

jorainer avatar jorainer commented on June 18, 2024 2

Closing this issue (the oldest one we've had still open!), because this feature is added in the new user interface functions: possibility to expand the are by a constant or relative value in both m/z and rt dimension.

from xcms.

stanstrup avatar stanstrup commented on June 18, 2024 1

Thanks. I did make a pull request for a minimum widths of mz and rt. Just used absolute widths instead of ppm. I think you also found a bug in my code though.
Right now there are only the expand options while the minimum options would be more helpful.

from xcms.

stanstrup avatar stanstrup commented on June 18, 2024

I have reopened this. See the pull request here: #3
What needs to happen to get this included?

from xcms.

stanstrup avatar stanstrup commented on June 18, 2024

Forgot to say that I would really like this included as soon as possible since the version the pull request was based on is no longer compatible with current versions of the dependencies, so I cannot use my fork.

from xcms.

stanstrup avatar stanstrup commented on June 18, 2024

Is it possible to use FillChromPeaksParam (so that you can use the ppm setting that sets a minimum width) in the old workflow?
I still consider this a pretty critical issue that current fillpeaks will try to integrate in an essentially 0 width m/z slice.

from xcms.

jorainer avatar jorainer commented on June 18, 2024

Unfortunately FillChromPeaksParam can not be used in the old workflow. The new fillChromPeaks uses completely different code, i.e. it really reads raw data to fill in peaks. In the old workflow, even if you used centWave and thus did never have the need for the profile matrix, the peaks are filled in from the profile matrix.

I'll check if and how I can include this parameter in the old workflow too.

from xcms.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.