Giter Site home page Giter Site logo

Comments (5)

jorainer avatar jorainer commented on June 3, 2024

Done that in 55817bd . For now I've just added additional functions/methods instead of replacing the original ones. If you find that acceptable (RUnit test confirms results are identical) I could go forward replacing the original ones, deprecating the old code (e.g. obsolete xcmsParallelSetup etc) and updating the documentation.

from xcms.

jorainer avatar jorainer commented on June 3, 2024

Aah sorry; I pushed to the wrong remote, i.e. directly to the devel branch instead of the devel branch of my fork.

Since the changes I made (commit e81b590) are mainly related to the parallel processing (i.e. use BiocParallel bplapply for parallel processing instead of the old code) there should be no big problem.

In addition I fixed some minor stuff in the NAMESPACE to reduce the warnings on package load.
I hope you find my changes acceptable. In future I will definitely avoid pushing directly to devel.

from xcms.

jorainer avatar jorainer commented on June 3, 2024

I think that issue can be closed; remains to bump the package version in DESCRIPTION and commit to Bioc svn.

from xcms.

rietho avatar rietho commented on June 3, 2024

To let you know: The manual of fillPeaks (xcms/man/fillPeaks.chrom-methods.Rd) does not show nSlaves as deprecated yet.

from xcms.

jorainer avatar jorainer commented on June 3, 2024

Thanks for looking into that! I'll fix.

from xcms.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.