Comments (5)
Done that in 55817bd . For now I've just added additional functions/methods instead of replacing the original ones. If you find that acceptable (RUnit test confirms results are identical) I could go forward replacing the original ones, deprecating the old code (e.g. obsolete xcmsParallelSetup
etc) and updating the documentation.
from xcms.
Aah sorry; I pushed to the wrong remote, i.e. directly to the devel branch instead of the devel branch of my fork.
Since the changes I made (commit e81b590) are mainly related to the parallel processing (i.e. use BiocParallel
bplapply
for parallel processing instead of the old code) there should be no big problem.
In addition I fixed some minor stuff in the NAMESPACE to reduce the warnings on package load.
I hope you find my changes acceptable. In future I will definitely avoid pushing directly to devel.
from xcms.
I think that issue can be closed; remains to bump the package version in DESCRIPTION and commit to Bioc svn.
from xcms.
To let you know: The manual of fillPeaks
(xcms/man/fillPeaks.chrom-methods.Rd) does not show nSlaves
as deprecated yet.
from xcms.
Thanks for looking into that! I'll fix.
from xcms.
Related Issues (20)
- Seeking advices about data importing HOT 5
- Suggested starting parameters for GC-MS data HOT 3
- reconstructChromPeakSpectra HOT 1
- Filter MsExperiment object by spectraData filterString HOT 16
- Bad practices with peak merging HOT 2
- msLevel=2L chromatograms (MRM or SRM) not working with MsExperiment interface HOT 1
- precusor charge for each features HOT 3
- fillChromPeaks error HOT 2
- Trouble plotting XChromatograms HOT 5
- R CMD check problems HOT 5
- xset crashes on MAC OS 14.3 R 4.3.3 , BiocManager 1.30.22 and xcms 4.0.2 HOT 6
- Update retention times to alkane retention time indices for GC-MS HOT 5
- The error message encountered when using the "IPO" package HOT 10
- Error for XIC plot of timsTof data HOT 3
- Best way to document additional XCMS object processing steps in the ProcessHistory slot? HOT 3
- After I perform chromatographic peak detection, how do I confirm the quality of my peaks? HOT 1
- Ways to extract all MS2 peaks? HOT 3
- Best way to deconvolute metabolite data HOT 1
- Waters data problems with Obiwarp HOT 9
- Support excluding samples for PeakDensity correspondence
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from xcms.