Add input for POETRY_HOME

[snok]

Add input for POETRY_HOME

[miigotu]

Opps that was a typo lol, editing that.

[sondrelg]

A PR for this is very welcome 👏 Thanks @linkous8

[linkous8]

Unfortunately, implementing this was not as straight forward as I thought it would be, the tests are all blowing up when run in my local repo: https://github.com/linkous8/install-poetry/actions/runs/994929613

Do you have any recommendations where I might be going wrong? If not, I can close out the PR to remove the needless clutter

[sondrelg]

Do they pass if you undo the changes? Or do they possibly fail because you're running the tests in a fork? 🙂

To give you some context: The reason I ended up setting the POETRY_HOME variable was because the Github action runners are inconsistent. If I remember correctly mac runners sometimes use ~/.local and sometime uses ~/Library/Application.

I can take a better look at it tomorrow if that doesn't help you 👍

[sondrelg]

Might be a good idea to comment out most of the tests when experimenting btw 🙂 I usually just keep one or two until I get it to work then comment the rest back in - otherwise it takes forever

[sondrelg]

In the final test run it looks like the condition isn't working

python3: can't open file 'default': [Errno 2] No such file or directory

Looks like it's just setting "default"

[linkous8]

Right, I have a conditional to set the path variable but its not working correctly for some reason:

https://github.com/snok/install-poetry/pull/40/files#diff-61368e2b75f4523e4d83149b45fae042b666e423a7d6455784a0a3519351064eR37

[miigotu]

@linkous8 why not make the default an empty string?

  poetry-home:
    description: "The Poetry installation path"
    required: false
    default: ""

if [ -z "$poetry_home" ]; then
  if [ "$os" == "Windows" ]; then
    path="C:/Users/runneradmin/AppData/Roaming/Python/Scripts/"
  else
    path="$HOME/.local/"
  fi
else
  path="$poetry_home_path"
fi

[sondrelg]

That seems sensible 🙂

Would this make sense @miigotu

if [ -z "$poetry_home" ]; then
  if [ "$os" == "Windows" ]; then
    path="C:/Users/runneradmin/AppData/Roaming/Python/Scripts/"
  else
    path="$HOME/.local/"
  fi
else
  path="$poetry_home_path"
fi

Or does the second path="$HOME/.local/" have a purpose?

[linkous8]

Opted for an alternative approach to caching, I no longer need support for this