Crash when try to edit the any Property in snoop

[tisis2]

Crash when try to edit the any Property in snoop

[tisis2]

i figured out that the issue only happens on properties that are edited via a textbox
additionally i was able to isolate the issue to a point where our applications sets the OverrideDefaultStyle property for textboxes in a default style. when i comment this setter, the crash does not happen.
still if i do the same in a small example project the crash does not happen yet

[batzen]

A repro would be very nice in this case.

[tisis2]

issue is reproducable with the following example:
SnoopCrashOnPropertyEdit.zip

i figured out that in the past the line FrameworkElement.StyleProperty.OverrideMetadata(typeof(TextBox), new FrameworkPropertyMetadata { DefaultValue = FindResource(typeof(TextBox)) }); was added in our App.xaml.cs. and the style sets the OverridesDefaultStyle Property to true. i have no idea why exactly this was done in the past but this is the cause of the crash

[batzen]

The crash in Snoop just reveals that your code is wrong.
You can test that by using my modified version of your repro.
SnoopCrashOnPropertyEdit.zip

The problem with your code is that you overwrite the default style, by changing the default metadata of the style property, and then also set OverridesDefaultStyle to true.
Which is something that's not allowed in WPF, at least if you want to also use controls inheriting from the same type.

[tisis2]

ok thanks i see. i removed the changing of the metadata in this case to fix that issue. i was just a bit confused because with older versions there was no crash