ArrayUtils not included in package

[snowflakedb]

ArrayUtils not included in package

[howryu]

@shanhija Adding a dependency is easy, but we want to keep list short and minimize the class files that will be added to self-contained-jar. I did a quick search in my projects and could not find any place that is using ArrayUtils.

Could you provide me a test case to reproduce the issue?

[jianshenghuang]

We can ask the user to provide the stack trace.

…

On Wed, Jan 31, 2018 at 9:59 AM, Haowei Yu ***@***.***> wrote: @shanhija <https://github.com/shanhija> Adding a dependency is easy, but we want to keep list short and minimize the class files that will be added to self-contained-jar. I did a quick search in my projects and could not find any place that is using ArrayUtils. Could you provide me a test case to reproduce the issue? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#9 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ATSrUiC46HFqiFcvRkYZTrhB3v1Rtc_Qks5tQKoTgaJpZM4Rz1MJ> .

[shanhija]

Here's the stack trace:

java.lang.NoClassDefFoundError: net/snowflake/client/jdbc/internal/apache/commons/lang3/ArrayUtils
	at net.snowflake.client.jdbc.internal.apache.commons.lang3.StringUtils.splitWorker(StringUtils.java:3042)
	at net.snowflake.client.jdbc.internal.apache.commons.lang3.StringUtils.split(StringUtils.java:2593)
	at net.snowflake.client.jdbc.SnowflakeConnectionV1.processParameters(SnowflakeConnectionV1.java:392)
	at net.snowflake.client.jdbc.SnowflakeConnectionV1.<init>(SnowflakeConnectionV1.java:201)
	at net.snowflake.client.jdbc.SnowflakeDriver.connect(SnowflakeDriver.java:344)
	at org.jkiss.dbeaver.model.impl.jdbc.JDBCDataSource.openConnection(JDBCDataSource.java:176)
	... 11 more

ArrayUtils is referenced in commons-lang3/StringUtils

[howryu]

It seems happening when dealing with connection parameters
@smtakeda @jianshenghuang I cannot reproduce it locally

javac TestJdbc.java
java -cp :snowflake-jdbc-3.4.1.jar TestJdbc

Note I only specified only jdbc jar file in classpath.

But anyway, I can see two solutions

1. Add ArrayUtils to self-contained-jar
2. Remove the dependency on StringUtils. Ideally, I want to remove the dependency on commons-lang3 completely so that no conflict would happen.

I prefer second solution. Do you have any idea/comment?

[jianshenghuang]

I like the second solution if it is possible and reasonable to do (e.g. w/o adding too much complexity by implementing some dependency functions. In general, if there is a way to get rid of a dependency w/o adding too much complexity, then it is worth doing.

…

On Thu, Feb 1, 2018 at 9:20 AM, Haowei Yu ***@***.***> wrote: It seems happening when dealing with connection parameters @smtakeda <https://github.com/smtakeda> @jianshenghuang <https://github.com/jianshenghuang> I cannot reproduce it locally javac TestJdbc.java java -cp :snowflake-jdbc-3.4.1.jar TestJdbc Note I only specified only jdbc jar file in classpath. But anyway, I can see two solutions 1. Add ArrayUtils to self-contained-jar 2. Remove the dependency on StringUtils. Ideally, I want to remove the dependency on commons-lang3 completely so that no conflict would happen. I prefer second solution. Do you have any idea/comment? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#9 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ATSrUsD_vtUv6f3OSsnpESu-GgKa4wG_ks5tQfJygaJpZM4Rz1MJ> .

[smtakeda]

+1 for the second option.

[shanhija]

+1 for the second option.

The problem emerges when the connection parameters are empty. Here's a test class that reproduces the issue when run with above commands :

import java.sql.DriverManager;
import java.sql.SQLException;

public class TestJdbc {
    public static void main(String[] args) throws ClassNotFoundException, SQLException {
        Class.forName("net.snowflake.client.jdbc.SnowflakeDriver");
        DriverManager.getConnection("jdbc:snowflake://dummy.eu-central-1.snowflakecomputing.com/?");
    }
}

[howryu]

Ok. I will go with second one. It seems a trivial change.

[howryu]

This is fixed in 9f7904e and already released in JDBC 3.5.3