Giter Site home page Giter Site logo

Comments (4)

 avatar commented on May 26, 2024

Thanks for the suggestion -- we are looking at this.

A question, though. Without an entry in the tables2topicsmap, we ingest topics into a table with the same name. This can cause problems with Snowflake's limitations on table names. E.g., we can't have a table with a hyphen, so we need to remap "my-topic" to something. But we can't extend the map to dynamically-added topics.

What would you prefer:

  1. We don't ingest new topics whose names are invalid Snowflake identifiers.
  2. We strip any non-conforming characters, and append a disambiguator to the name. E.g., "foo-bar" might become "foobar_12349876".

from snowflake-kafka-connector.

yarmiganosca avatar yarmiganosca commented on May 26, 2024

I think as long as you logged that the attempt had been made, with the offending topic name, and the logs weren't flooded with that (so like no more than once every five seconds per offending topic plz plz), we can handle that on our end. We're controlling topic names with a ruby gem that handles Avro schema encoding and publishing to a topic, so we're already abiding by the Snowflake table name rules, but I think logging is at least a good first step for a good general failure behavior.

from snowflake-kafka-connector.

iexos avatar iexos commented on May 26, 2024

We auto-generate the table name in the map anyway. The corresponding part in the shell script is:

table=$(echo $topic | tr '.[:lower:]' '_[:upper:]')

This works pretty well for us, as we only have dots as special characters in topic names. In my view the second option is preferred, as our team is just one of many users of Kafka and cannot control the naming convention just for this connector.

from snowflake-kafka-connector.

binglihub avatar binglihub commented on May 26, 2024

4db8759

from snowflake-kafka-connector.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.