Comments (3)
A side note, Data.Map.Strict.Map
and Data.Map.Lazy.Map
are the same datatype! (only functions differ).
I'd prefer to have different names for the types, as the functions will be the same, thanks to the type class machinery,
from alga.
Perhaps, a slightly better approach would be to stick to the name Graph
, but use module names to distinguish between general and non-empty graphs?
More specifically:
module Algebra.Graph.NonEmpty (Graph (..)) where
data Graph a = Vertex a
| Overlay (Graph a) (Graph a)
| Connect (Graph a) (Graph a)
Now, if one would like to be explicit about the data type, it's possible to write NonEmpty.Graph
. And if non-empty graphs are assumed throughout the codebase, then a simple Graph
will work.
This is similar to Data.Map.Strict
and Data.Map.Lazy
that both definine data type Map
.
Following this approach we can also have Undirected.Graph
, Reflexive.Graph
, Undirected.NonEmpty.Graph
etc. without the need to invent longer and longer names for various graph data-types.
from alga.
Done!
@phadej Thanks for the suggestion and let me know if you spot any issues with the implementation.
I decided not to add a type class for non-empty graphs for now. I think it deserves a new issue.
from alga.
Related Issues (20)
- How to handle goodness inherited from other libraries HOT 2
- Bump upper bound for base-compat for version 0.4 on Hackage HOT 4
- Unable to use ghcid HOT 6
- Algorithms should be in terms of typeclasses not data structures HOT 15
- Acyclic graphs with Int labels HOT 5
- Tests failed to build with QuickCheck 2.14.2
- Multitree HOT 3
- Monoid instance HOT 6
- support for GraphViz "HTML strings" for node or edge labels HOT 1
- Add benchmarks to CI HOT 2
- Supporting different node and edge types HOT 7
- v0.6 fails to build with GHC 8.0 and 8.2 HOT 3
- Doubt about decorating a Graph HOT 4
- Compatibility with mtl-2.3 HOT 2
- Smart constructor for Symbol rather than requiring -XOverloadedLists HOT 1
- Proposal : foldgM HOT 2
- Algebra.Graph.Labelled.AdjacencyMap.edges appears to be broken HOT 2
- Semigroup version of Algebra.Graph.Labelled.AdjacencyMap HOT 7
- Bump "deepseq" dependency bounds to 1.5.0.0 HOT 2
- Warnings when building with ghc-9.10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from alga.