Giter Site home page Giter Site logo

Oracle incorrect DDL handling about soci HOT 2 OPEN

Sildra avatar Sildra commented on June 6, 2024
Oracle incorrect DDL handling

from soci.

Comments (2)

Sildra avatar Sildra commented on June 6, 2024

Proposal for the fix :
Sildra@63d20b5

SOCI may truncate integer with 10 digits.
SOCI may ignore the sign of unsigned long long (integer with 20 digits).
SOCI handle doubles perfectly.

from soci.

vadz avatar vadz commented on June 6, 2024

Using binary_double for double columns looks like a good idea (as an aside, we should drop get_double_sql_type() and just use SQLT_BDOUBLE, it seems useless to keep compatibility with Oracle 9.x and earlier which is surely not used any more?) and so does using the correct precision for number, so please don't hesitate to make a PR with your changes.

If I could wish for something here, it would be to make the test code simpler to understand as it's really difficult to follow. Generally speaking, the more straightforward the testing code is, easier it is to fix any problems when it breaks, so it would be nice to keep it as simple as possible even at the price of making it less generic/complete.

TIA!

from soci.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.