Giter Site home page Giter Site logo

Comments (3)

bielfrontera avatar bielfrontera commented on May 16, 2024

Hi Claudio,
thanks for your comment.

I've checked the plugin with leaflet-1.0.0-b1, and I get the same error, provoked because the custom layer implemented in TimeDimension does not have the method _layerAdd. According to the new documentation, now custom layers should extend L.Layer instead of L.Class.

So, I've changed

L.TimeDimension.Layer = L.Class.extend({

by

var baseClass = L.Layer || L.Class;
L.TimeDimension.Layer = baseClass.extend({

in https://github.com/socib/Leaflet.TimeDimension/blob/master/src/leaflet.timedimension.layer.js#L8, and our examples seem to work fine with leaflet-1.0.0-b1 and leaflet-0.7.3.

I will commit the changes in a few days, but I'm not sure this is the best solution to work with old and new releases of Leaflet. @mourner, could you give us some advice? Thanks!

from leaflet.timedimension.

mourner avatar mourner commented on May 16, 2024

(L.Layer || L.Class).extend(...) is how I did this in my own plugins :)

from leaflet.timedimension.

ClaudioCas avatar ClaudioCas commented on May 16, 2024

Thanks a lot. The patch works great and thanks for update the library!

from leaflet.timedimension.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.