server stops if you send it an unrecognized command

[sockethub]

server stops if you send it an unrecognized command

[silverbucket]

Could you let me know what you tried to send?

Obviously, it's designed not to fail when an unknown command is sent, so
this is a bug, but I need to know steps to reproduce so I can write a test
for it..

On Thu, Mar 14, 2013 at 10:11 PM, Michiel@unhosted <[email protected]

wrote:

/root/run/sockethub/lib/protocols/sockethub/dispatcher.js:373
var report = jsv.validate(o, proto.verbs[verb].schema);
^
TypeError: Cannot read property 'schema' of undefined
at
WebSocketConnection.Dispatcher.connect.connection.sendUTF.JSON.stringify.rid
(/root/run/sockethub/lib/protocols/sockethub/dispatcher.js:373:57)
at WebSocketConnection.EventEmitter.emit (events.js:93:17)
at WebSocketConnection.processFrame
(/root/run/sockethub/node_modules/websocket/lib/WebSocketConnection.js:403:26)
at WebSocketConnection.handleSocketData
(/root/run/sockethub/node_modules/websocket/lib/WebSocketConnection.js:247:14)
at Socket.EventEmitter.emit (events.js:93:17)
at TCP.onread (net.js:396:14)

it should catch this and reply 'command unrecognized', 'platform
unrecognized', 'unparseable', etcetera. nothing you throw at it should
cause it to topple.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/61
.

[silverbucket]

added a second test, can't reproduce. couldn't push my repo for some reason because of this crappy internet connection, but the second test is on my system and neither the existing one, or the new one, can create you error. they both handle unknown verbs gracefully.

please when you run into bugs assume it's a bug instead of reporting it like it's a feature request. give me more information otherwise i have no reproduce-able information to go on an have to assume it's a user error.

[silverbucket]

@michielbdejong can you let me know whether you're able to provide me with more information? otherwise i'm going to close this because i've checked for this since day one, have 2 tests, and haven't run into it myself.
so there's something you're doing differently that I need to know of if i'm to try to address this.

[michielbdejong]

hm, in that case maybe i got it wrong. it's possible that i had announced a verb in protocol.js but not in verbs_schema.js. that's obviously not something that needs checking