Coolio::HttpClient never calls on_request_complete

[socketry]

Coolio::HttpClient never calls on_request_complete

[dnwade]

I can confirm this error. Here are three examples using your subclass:

l = Coolio::Loop.default
msn = MyHttp.connect("www.msn.com").attach(l)
msn.request("GET", '/')
l.run

This prints "HTTP FINISHED". The response_header contains a "content-length" header (and no "transfer-encoding: chunked" header).

l = Coolio::Loop.default
ip = MyHttp.connect("jsonip.com).attach(l)
ip.request("GET", '/')
l.run

This too prints "HTTP FINISHED". There is a "transfer-encoding: chunked" header present (but no "content-length" header).

Finally, trying your "www.google.com" example does not print "HTTP FINISHED", i.e.: on_request_complete is not called. And both those headers are not defined.

I think this problem can be traced to the following source from Coolio::HttpClient#process_body (cool.io/http_client.rb):

  if @bytes_remaining.nil?
    on_body_data @data.read
    return false
  end

This code is evaluated if and only if the server has not set both the "Transfer-Encoding: chunked" header and the "Content-Length" header since Coolio::HttpClient sets @bytes_remaining to nil. Hence, @State is never changed from :body to :finished and on_request_complete never gets called.

One work around would be to set a callback that calls on_request_complete whenever the server closes the TCP connection and those two HTTP headers are unset. I'm not entirely sure about the correct way to do this with the Coolio API though.

Would you define HttpClient#on_close? If so, how?