Comments (20)
Would be amazing to see this updated to include v5 support!
from acf-field-date-time-picker.
Hope, that there will be an update
from acf-field-date-time-picker.
Hi @soderlind !
Same here it doesn't work with ACF 5 :(
from acf-field-date-time-picker.
I would also love to see this one updated to support V.5 / PRO :-)
And besides that thank you so much for a lovely extension!
from acf-field-date-time-picker.
I'd love to see this work again as well and would be happy to help in any way I can.
from acf-field-date-time-picker.
I have just submitted an update to version 5.0, however the fields doesn't save the options correct and I can't seem to figure out why i doesn't work. if you @michaelsilva can figure it out why, please let me know.
from acf-field-date-time-picker.
Fixed the bug with options not being saved. Front end doesn't work atm.
from acf-field-date-time-picker.
I've corrected the plugin and updated it to rung with version 5.0 / PRO. Until @soderlind checks it out and merges into master branch, you can pull of my fork here: https://github.com/yanknudtskov/acf-field-date-time-picker
from acf-field-date-time-picker.
Hmm just discovered there is a minor "bug" my fork, after you save the page/post that has the field in it, the value will be displayed as a timestamp and not the formatted version of it. Trying to figure out why that happens.
Other than that, it works just fine. So functionally it seems intact :-)
from acf-field-date-time-picker.
Aah, finally figured it out. Had forgot to add the load_value() function to the plugin. Everything seems to be fine and dandy now.
from acf-field-date-time-picker.
Nice work! I will test your fork on my project tomorrow.
from acf-field-date-time-picker.
@bostondv Thanks! Let me know if it works or not :-)
from acf-field-date-time-picker.
@yanknudtskov It works great for me ๐
Just one issue, I get a PHP notice once the plugin is activated and when adding new fields with the date time picker type
Notice: Undefined property: acf_field_date_time_picker::$domain in ./plugins/acf-field-date-time-picker/date_time_picker-v5.php on line 20
I suggest you open a pull request and hopefully @soderlind can merge it soon!
from acf-field-date-time-picker.
@bostondv Thanks :-) I've just opened a pull request.
from acf-field-date-time-picker.
@yanknudtskov Great work! Thanks for this. Small bug: when this plugin is activated it seems to cause some trouble with the standard date-picker fields. When I open an edit page containing a date-picker field and scroll to the bottom, the date-picker dialogue is appearing at bottom left:
Deactivating your patched date-time-picker stops this happening. Minor bug, I know, otherwise all working wonderfully!
from acf-field-date-time-picker.
@delucis Thanks! Hmm that's weird, I haven't seen that bug before. I haven't changed any of the JS behind the extension, so it must've been there all the time. Is it a consistent bug you can reproduce even if you make a new Custom Field template?
from acf-field-date-time-picker.
@yanknudtskov Yes, just tried creating a new custom field group on the default post type which doesnโt have any existing custom groups. Even with just a default date picker, the same thing happens (i.e. no date-time-picker field needs to actually be displayed to reproduce the bug, just for the plugin to be activated). Tried various combinations, same result. The install is pretty clean, so as far as I can tell nothing else could be interfering.
from acf-field-date-time-picker.
@delucis Ah I think I found the bug. There was a CSS issue where there was a missing display:none on a class.
I've corrected it now and can't seem to reproduce the bug anymore. Could you please verify it? You can just pull it off my fork :-)
from acf-field-date-time-picker.
@yanknudtskov Yes! Thatโs fixed it. Thanks again for the work ๐
from acf-field-date-time-picker.
I think that 'var $domain' is missing in date_time_picker-v5.php
class acf_field_date_time_picker extends acf_field
{
var $domain;
from acf-field-date-time-picker.
Related Issues (20)
- Date only request HOT 1
- readonly Setting is Missing.
- After acf Update class acf_field_date_time_picker is declared more than once HOT 15
- Cannot save a time output that does not show a date HOT 1
- EOL ACF PRO 5.0 support (?) HOT 2
- Re-adding support for ACF PRO HOT 4
- Limit timespan
- Setting a default time using the time only option in ACF HOT 4
- "English (Canada)" WordPress Regional Setting Interpreted as Catala
- Php error (uncaught error calling undefined function) HOT 1
- UI time picker doesn't run? HOT 2
- Save and Get in ISO 8601 Format HOT 1
- Feature request: Bind the "Now" button to the site's timezone setting
- Is this maintained?
- Can't include in plugin HOT 3
- Can't order posts correctly, because saving as timestamp doesn't work!
- Year and month reversed using timestamps HOT 1
- Saving as timestamp doesn't work HOT 2
- Time Picker doesn't show on Front End HOT 1
- How i call the picker in other admin inputs? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from acf-field-date-time-picker.