Comments (6)
Hi. I just have noticed that you updated the code fff3982. That's fine, but you are the developer and don't have to follow any wish. Thanks.
Because of this new behavior of FlowSOM, I was a little bit worried about the mapping of new data. I reviewed the code in that view, and I am pretty sure you already did, but I will appreciate if you could check again the impact of the absence of the spillover in the FlowSOM object when mapping new data to it.
I think that the code should check that the spillover argument is a matrix at
Lines 164 to 166 in fff3982
Best.
from flowsom.
Hi, thank you very much for your input!
I thought with the last update to the code, I addressed the issue you specified before:
If spillover is NULL en compensate is TRUE, we will always look for the file-specific one, instead of accidentally reusing the first one. Alternatively, if spillover is not NULL, the given value (indeed assumed to be a matrix, I can add the check) will be used.
For the NewData function, the spillover argument that is passed to this function call will have precedence: if this contains a matrix, this is used. If it is NULL, I assume the user wants to do the same as in the original FlowSOM call, i.e. using the specified matrix value from that spillover argument, or if it was NULL in the original call as well, we look for the spillover matrix identified in the file.
Could you explain clearer to me what you think is going wrong in the current version of the code? I am not sure if I understand your last remark.
Best,
Sofie
from flowsom.
Nothing's wrong with the current code.
I checked your first point and agreed.
I wanted to be absolutely sure about how NewData will manage flowFrame when compensate is TRUE but spillover is NULL.
The 3rd point is an addendum in order to verify that the argument passed to spillover is of class "matrix" in the same way it is done a few lines above and to throw an error if it is not.
Line 148 in fff3982
Best.
from flowsom.
Dear Sophie,
Many thanks for FlowSOM! I'm very excited to use it. I am having trouble with the method AddFlowFrame(). Specifically, the function doesn't appear to exist. I've just updated R to the latest stable version, 3.6.0, and installed FlowSOM v1.16.0 using BiocManager::install("FlowSOM").
I have done extensive pre-processing (compensation, transformation, and pre-gating) on my data outside of FlowSOM, and everything is held in a flowSet. I built a FlowSOM object on an aggregated and sampled subset of the data (for efficiency) and now would like to add back all of the original data. It seemed like AddFlowFrame could be used iteratively for each frame of the flowSet. However, it does not appear that the function AddFlowFrame() exists. Could you let me know if I'm doing something wrong or if you have any suggestions?
Many thanks again!
Wade
from flowsom.
from flowsom.
Many thanks Sofie. Will give it a go!
Cheers,
Wade
from flowsom.
Related Issues (20)
- SOM should protect against inputs with no column names HOT 6
- Is the integer cast in abs() really intended? HOT 3
- Accessing MapDataFromCodes in FlowSOM/installation error using devtools HOT 7
- GetFlowJoLabels error: FCS files not found HOT 2
- Calling FlowSOM:::MapDataToCodes produces a segmentation fault HOT 3
- Elbow plot variance calculation HOT 3
- Speedup when threshold < 1
- No output
- FlowSOM installation issues with boost library
- Add option to return just the weights from the`SOM` function
- Release version out of date compared to Flowjo Plugin. HOT 4
- Calling MapDataDataToCodes produces long vectors error HOT 8
- Long Vectors error in SOM Function (Analogous to issue #54) HOT 4
- Building error on Bioconductor HOT 3
- AggregateFlowFrames with channels given produces error HOT 1
- Porting FlowSOM to python HOT 1
- unable to find an inherited method for function ‘compensate’ for signature ‘"flowFrame", "NULL"’ HOT 2
- Error while using GetFeatures to map files HOT 5
- Using `importance` argument for SOM mapping? HOT 2
- Clusters with similar marker expression level are not clustered in the same metacluster HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flowsom.