Giter Site home page Giter Site logo

Comments (4)

qwerttvv avatar qwerttvv commented on June 9, 2024 2

@qwerttvv if you get a chance to check I've made that change in behavior opt in an updated the v2 tag to include those changes

Thanks, just tested it and that problem is solved, thanks again

from action-gh-release.

softprops avatar softprops commented on June 9, 2024

I suspect this is a new behavior introduced with #384 which I believe intended to surface mismatches patterns less quietly

I believe prior to that users had to opt into failing on mismatched patterns

if (patterns.length > 0 && config.input_fail_on_unmatched_files) {

If I’m reading the message above correctly it sounds like there were some files previously matched and some unmatched. I think the right thing to do is to make the previous change opt in so existing usages are impacted.

I’ll try to get that fix in this weekend.

from action-gh-release.

qwerttvv avatar qwerttvv commented on June 9, 2024

I suspect this is a new behavior introduced with #384 which I believe intended to surface mismatches patterns less quietly

I believe prior to that users had to opt into failing on mismatched patterns

if (patterns.length > 0 && config.input_fail_on_unmatched_files) {

If I’m reading the message above correctly it sounds like there were some files previously matched and some unmatched. I think the right thing to do is to make the previous change opt in so existing usages are impacted.

I’ll try to get that fix in this weekend.

Thanks a lot!

I'll keep using master to help with testing, or if you have another branch enabled on your end, let me know and I can help with testing :)

from action-gh-release.

softprops avatar softprops commented on June 9, 2024

@qwerttvv if you get a chance to check I've made that change in behavior opt in an updated the v2 tag to include those changes

from action-gh-release.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.