Giter Site home page Giter Site logo

Comments (3)

kmagiera avatar kmagiera commented on May 26, 2024

Thanks @rozele for reporting. Will look into this soon

from react-native-gesture-handler.

kmagiera avatar kmagiera commented on May 26, 2024

So the issue was that we werend handling GH lifecycle propertly as it was bound to the underlying native view. When you swap out one of the handlers then the top one stays the same and the underlying view gets recreated. This should result in handler sticking around but just updating its target view. But instead we were dropping all the handlers when the view got unmounted.

To fix this I had to change the bridge API by adding attachGestureHandler as well as changing the contract of createGestureHandler or updateGestureHandler methods which now no longer take viewID as an argument. Also dropGestureHandler method replaced dropGestureHandlersForView to allow for deleting handlers selectively.

Changes are not yet merged and you can play with them here: https://github.com/kmagiera/react-native-gesture-handler/tree/bridge_api_change

Thanks again for your feedback @rozele

from react-native-gesture-handler.

kmagiera avatar kmagiera commented on May 26, 2024

Fixed in #24
Thanks again for reporting

from react-native-gesture-handler.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.