Comments (3)
Thanks @rozele for reporting. Will look into this soon
from react-native-gesture-handler.
So the issue was that we werend handling GH lifecycle propertly as it was bound to the underlying native view. When you swap out one of the handlers then the top one stays the same and the underlying view gets recreated. This should result in handler sticking around but just updating its target view. But instead we were dropping all the handlers when the view got unmounted.
To fix this I had to change the bridge API by adding attachGestureHandler
as well as changing the contract of createGestureHandler
or updateGestureHandler
methods which now no longer take viewID as an argument. Also dropGestureHandler
method replaced dropGestureHandlersForView
to allow for deleting handlers selectively.
Changes are not yet merged and you can play with them here: https://github.com/kmagiera/react-native-gesture-handler/tree/bridge_api_change
Thanks again for your feedback @rozele
from react-native-gesture-handler.
Fixed in #24
Thanks again for reporting
from react-native-gesture-handler.
Related Issues (20)
- Expo app crashes when using GestureDetector HOT 9
- TurboModuleRegistry.getEnforcing(...): 'RNGestureHandlerModule' could not be found HOT 12
- Unable to resolve "./TouchableNativeFeedback" from "node_modules/react-native-gesture-handler/src/components/touchables/index.ts" HOT 1
- Some performance issues when combining FlatList, react-native-gesture-handler, and react-native-reanimated HOT 1
- Privacy Info HOT 4
- Touchables do not register taps in nested FlatList on iOS
- Combining Pan Gesture and Swipeable creates unexpected behavior HOT 4
- [Web] Nested Pressable inside a Swipeable captures press when swiping
- Improve Gradle build by declaring output HOT 2
- manualActivation doesn't work in the Web. HOT 6
- Pan gesture always runs simultaneously with the PagerView
- Event callback is not running in ui thread. HOT 2
- Pan gesture with manual activation disables responding of any touchable in the app
- `isFormsStackingContext(node)` does not have NativeState on react-native 0.73 HOT 3
- Certain classes (ScrollView, RNGHTextInput) no longer exporting type HOT 6
- Gesture.Pan() causing excessive re-renders (too slow) HOT 2
- Build error: "2 files found with path 'lib/arm64-v8a/libjsi.so" HOT 4
- `RectButton`, `BorderlessButton` and `BaseButton` don't have support for View ref methods
- WEB/NATIVE inconsistent behaviour of pan gesture callbacks with manual activation. HOT 1
- New architecture crashes on React Native < 0.74 (`Assertion failed: (hasNativeState<T>(runtime))`) HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-native-gesture-handler.