Giter Site home page Giter Site logo

Comments (19)

tboba avatar tboba commented on May 26, 2024 7

That's great to hear! Now I can sleep well 😄 🚀
I'll assume this issue can be closed for now, but if anyone is still impacted of this error, feel free to comment your scenario below.

Cheers 🙏

from react-native-screens.

tboba avatar tboba commented on May 26, 2024 5

Hi @kuzkokov, @donutdonate - thanks for reporting this. Yeah, looks like we didn't cover .gitmodules file we've added recently 😓 We'll take care of this in upcoming days. For now, you can stay with the 3.29.0 version to build Screens on CI. If it's possible for you, please wait up to 15-30 minutes for the new patch release.
Thank you for your patience 🙏

from react-native-screens.

Lump01 avatar Lump01 commented on May 26, 2024 4

Thanks for the speedy fix @tboba

from react-native-screens.

FraserKemp avatar FraserKemp commented on May 26, 2024 3

@tboba Just tested this now on 3.30.1 and it all seemed to work for me! Thanks for the speedy fix !

from react-native-screens.

tboba avatar tboba commented on May 26, 2024 2

The patch has been released! Could you check whether this issue is fixed in 3.30.1?

cc @kuzkokov @donutdonate @short-dsb @Alexandre-Cornillon @akeva001 @Lump01 @efstathiosntonas @twokilohertz @cubancodepath @mohd-ramzan-1

from react-native-screens.

Alexandre-Cornillon avatar Alexandre-Cornillon commented on May 26, 2024 2

3.30.1 worked nice for me too :) Big thanks 👍

from react-native-screens.

tboba avatar tboba commented on May 26, 2024 1

@efstathiosntonas okay, let me quickly check this change with npm pack 🙏

About the offtopic - that's because this nightly has been made for the purposes of making goBackGesture work before the PR with implementing the functionalities on reanimated has been merged 😄

from react-native-screens.

tboba avatar tboba commented on May 26, 2024 1

cc @aditya063 @FraserKemp (I see you've also reacted to the issue)

from react-native-screens.

Lump01 avatar Lump01 commented on May 26, 2024 1

I was able to install 3.30.1 successfully!

from react-native-screens.

efstathiosntonas avatar efstathiosntonas commented on May 26, 2024 1

3.30.1 worked as a charm, thank you @tboba for the really quick fix.

from react-native-screens.

github-actions avatar github-actions commented on May 26, 2024

Hey! 👋

The issue doesn't seem to contain a minimal reproduction.

Could you provide a snack or a link to a GitHub repository under your username that reproduces the problem?

from react-native-screens.

donutdonate avatar donutdonate commented on May 26, 2024

faced with the same issue

from react-native-screens.

cubancodepath avatar cubancodepath commented on May 26, 2024

Same issues in React Native (without expo)

Step to reproduce

npm i react-native-screens

image

from react-native-screens.

efstathiosntonas avatar efstathiosntonas commented on May 26, 2024

same here on CI

➜  ~ cat  /private/var/folders/cm/2r_39vcd593436b3_ht4nyqw0000gp/T/xfs-56d7b1c0/build.log
# This file contains the result of Yarn building a package (react-native-screens@virtual:e76baedaa29db3684127472f1ffb54fc23b24818fe3b47237f9ea5a6c6226499143d9e7f52c3ec3524b3e879b25ce856756a7143b6b085990b2cef70a047c6d9#npm:3.30.0)
# Script name: postinstall

cd: no such file or directory: react-navigation

from react-native-screens.

tboba avatar tboba commented on May 26, 2024

@efstathiosntonas @cubancodepath @kuzkokov @short-dsb @Alexandre-Cornillon @donutdonate @kuzkokov @akeva001 @Lump01

Could you please check whether the newest commit in 3.30.0 branch resolves the issue with builds and that your app works correctly while using the version from branch?

Please change in package.json version of react-native-screens to:

"react-native-screens": "software-mansion/react-native-screens#3.30.0"

from react-native-screens.

efstathiosntonas avatar efstathiosntonas commented on May 26, 2024

@tboba can't install with yarn 4.1.1 🤷 , it stucks here:

[4/4] Building fresh packages...
$ git submodule update --init --recursive && (cd react-navigation && yarn)
Submodule 'react-navigation' (https://github.com/react-navigation/react-navigation.git) registered for path 'react-navigation'
Cloning into '/private/var/folders/tc/sj1dwpmd3wx006fkwntygshh0000gn/T/xfs-815f8c19/react-navigation'...

offtopic: Why reanimated is pinned at 3.7.0-nightly-20240109-9e2c33716 on package.json? 🤔

from react-native-screens.

Lump01 avatar Lump01 commented on May 26, 2024

@efstathiosntonas @cubancodepath @kuzkokov @short-dsb @Alexandre-Cornillon @donutdonate @kuzkokov @akeva001 @Lump01

Could you please check whether the newest commit in 3.30.0 branch resolves the issue with builds and that your app works correctly while using the version from branch?

Please change in package.json version of react-native-screens to:

"react-native-screens": "software-mansion/react-native-screens#3.30.0"

Still getting the issue with the submodule.

npm ERR! command sh -c git submodule update --init --recursive && (cd react-navigation && yarn)
npm ERR! npm ERR! fatal: not a git repository (or any of the parent directories): .git

Could it be that the pipeline failed for the branch of react-navigation y'all are pulling in as a submodule?

react-navigation 523fa4f

from react-native-screens.

tboba avatar tboba commented on May 26, 2024

@Lump01 that's strange 🤔 but this is not caused from react-navigation for sure.

from react-native-screens.

tboba avatar tboba commented on May 26, 2024

Great @FraserKemp, thanks for letting me know! I'll wait for the opinion from others before closing this issue. Can anyone also confirm this error doesn't happen anymore?

from react-native-screens.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.