Giter Site home page Giter Site logo

Comments (10)

holmes1412 avatar holmes1412 commented on May 7, 2024

看起来是解析时候错了,我们回头改一下~感谢小伙伴!

from srpc.

Barenboim avatar Barenboim commented on May 7, 2024

这个好像是我们解析器没有做赋初值的解析。另外还有个const xxx=xxx 也不支持。
我们这边可能要等元旦之后才有人手修复这个问题。

from srpc.

qchenzi avatar qchenzi commented on May 7, 2024

这里有个疑问补充一下哈,这里将thrift语法中enum枚举类型转换为int32是出于什么目的呢?
企业微信截图_6f99b628-5ded-4441-81c2-246eb6d5fc88

虽说枚举类型可以强转为int32,但是下图中原生thrift框架生成的桩代码并没有将枚举类型用int32替代
企业微信截图_d9c12498-bef5-4d65-a62b-f3d7120f75e1

from srpc.

Barenboim avatar Barenboim commented on May 7, 2024

@hihybin
麻烦看看enum这个我们这么处理对不对。

from srpc.

hihybin avatar hihybin commented on May 7, 2024

猜测这里用int32_t是为了实现简单些,thrift协议里会把enum作为int32_t处理,这里写int32_t不会对协议造成影响,暂时就不修改了

from srpc.

Barenboim avatar Barenboim commented on May 7, 2024

我重新提了这个parser的修改PR了。

from srpc.

qchenzi avatar qchenzi commented on May 7, 2024

printer改的不多,应该大佬直接拷贝一下就没问题了

from srpc.

holmes1412 avatar holmes1412 commented on May 7, 2024

@qchenzi 麻烦重新pull一下代码然后重新提一下pr哈~thrift语法你比较熟,printer你来改比较合适的~

from srpc.

Barenboim avatar Barenboim commented on May 7, 2024

@qchenzi 我把printer也提交了。在你的基础上做了点修改。

from srpc.

qchenzi avatar qchenzi commented on May 7, 2024

好的哈,之前事情多给搞忘了

from srpc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.