Giter Site home page Giter Site logo

Comments (3)

efairon avatar efairon commented on June 11, 2024 1

client...Do() is not a goroutine.

We forked and adapt the code to run in go routine.
Be aware you can't handle the error returned by elasticsearch ...

In our case we don't care, we need the log to be fast. Using the goroutine is 1000 times faster than original code.

from elogrus.

sohlich avatar sohlich commented on June 11, 2024

The problem here is that you can leak the goroutines because this concept is fire and forget. And in extream case, you will get in troubles. Maybe this could be handled by pooling, so let's say you can have 20 parallel requests to elastic in one time.

from elogrus.

sohlich avatar sohlich commented on June 11, 2024

The asynchronous hook added you can create the async hook by NewAsyncElasticHook function.

from elogrus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.