Autofix broken for index file imports

[solana-labs]

Autofix broken for index file imports

[tpluscode]

Sorry, I expressed myself poorly. IMO, the plugin behaves as expected: it adds extension to an import.

I suppose it could be implemented to check for the existence of ./index.(ts|js) and fix accordingly. I would just propose to cater for the edge case where both ./externalTypes.ts and ./externalTypes/index.ts exist. In such case there should be no auto-fix to ensure that the correct alternative is chose.

[tpluscode]

Just a quick not before I forget. Rather than checking for the index.?? file, the code would better check whether the given path is a dir and in such case append /index.js, which would equally work for JS and TS.

Would still fail for index.mjs but that might be a rare case, requiring manual fix

[tpluscode]

Are you sure that import * from ./externalTypes is a valid ES import? I would think that for relative paths they must be exact.

The extensionless modules are only valid when importing a module explicitly listed in package.json exports

[trevor-scheer]

I'm not sure I understand your question. My understanding is that this plugin exists to lint against and correct invalid imports which are missing the extension.

So directly, no, import * from ./externalTypes is not a valid ES import (since it has no extension). But this plugin is here to detect and correct it to the right thing (which I am very happy about).

What I'm suggesting is that the autofix behavior is incorrect for this scenario. The fixer needs to be aware of the existence of the file. If it doesn't exist, it should look to see if there's an index file in that path and use it appropriately.

So, since there is no actual externalTypes.js file, it should then look for an externalTypes/index file and use that in the fix if it exists. Hopefully that makes sense, let me know if anything is unclear.

[trevor-scheer]

Agreed. I'm not sure if or when I'd get to it, but would you be open to a PR that implements that? If the answer is yes and someone beats me to it that's fine too 😄

[tpluscode]

I'm not the author here. I just opened another PR myself recently. Not saying I would not open the PR but no promises ;)

[trevor-scheer]

Oh, whoops! I just assumed. Thanks for letting me know.

[jordaaash]

#3 (comment)

@tpluscode's fix for non-JS imports was just merged and released. I think a slightly modified approach could work for this issue also. I personally use index imports and run into this quite a bit.

[tpluscode]

I use index import too. One that I added your plugin to my base config I'm surely going to hit this issue on occasion.

Happy to submit a PR when this happens