Giter Site home page Giter Site logo

Comments (11)

github-actions avatar github-actions commented on September 15, 2024

This Feature is ready to be implemented.

from seliproject.

github-actions avatar github-actions commented on September 15, 2024

This Feature is ready to be implemented.

from seliproject.

juantenesaca avatar juantenesaca commented on September 15, 2024

In this aria-labels, ids and labels, do I have to use the variables of props.language or is it ok to just use English on everything? or just for aria-labels.

from seliproject.

ecureuill avatar ecureuill commented on September 15, 2024

Everything that user will access (read, hear) should be with props.language. : labels, aria-label, aria-describedby, name, title, etc

id just need to be unique, so for reusable components create an id with {some_prefix}+{id}
https://lodash.com/docs#uniqueId

import React, { useState } from 'react'
import uniqueId from 'lodash/utility/uniqueId'

const Field = props => {
  const [ id ] = useState(() => uniqueId('myprefix-'))

  return (
    <div>
      <label htmlFor={id}>{props.label}</label>
      <input id={id} type="text"/>
    </div>
  )      
}

export default Field

from seliproject.

juantenesaca avatar juantenesaca commented on September 15, 2024

OK that is good. But, for now let's left it until new features of instructional design were completely implemented. Because if we start now with it. Then you have to review again.

from seliproject.

github-actions avatar github-actions commented on September 15, 2024

This Feature is ready to be implemented.

from seliproject.

ecureuill avatar ecureuill commented on September 15, 2024

@juantenesaca when you finish, just move the card to CODED list.
image

The 2 - Ready, means it' ready to be coded (after specification phase).

from seliproject.

github-actions avatar github-actions commented on September 15, 2024

This feature have been implemented and is ready for Funcional Test.
Please, test the feature.

from seliproject.

github-actions avatar github-actions commented on September 15, 2024

This Feature is ready to be implemented.

from seliproject.

github-actions avatar github-actions commented on September 15, 2024

This Feature is ready to be implemented.

from seliproject.

ecureuill avatar ecureuill commented on September 15, 2024

Failures

Course Topic

  • due to breadcrumb
  • due to missing Accessible Name
    image
  • due to close button at course menu
    image

Course Content

  • due to missing Accessible Name or Accessible Description for audio component
    image
  • due to missing Accessible Name for StoryTelling player component
    image
  • due to frames without title
  • due to emulating link instead of use <a> in Link component
  • due to speed dial control
    image

from seliproject.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.