Comments (20)
This Feature is ready to be implemented.
from seliproject.
I have reviewed the code and it has the requested requirements:
Add aria tag in RadioGroup
Add label attribute in FormControlLabel
Add control attribute to option render as a native component
I've tried ChromeVox and Read Aloud text-to-speech reader and it has no problems reading labels
from seliproject.
@CAndresH I did a suggestion with RadioGroup (in November/2019 it was coded as a radio), But I now notice that have changed for checkboxs.
So need to check the Material-Ui component and the the WAI-ARIA Practice Guides to correct the accessibility.
Please, check this video
https://drive.google.com/open?id=155Cf5EKMU42RNz74ZKzVz2SWIb414zIA
I'm showing you what should be the result (with WAI-ARIA example) and how currently is the output in SELI
See the documentations
https://material-ui.com/components/checkboxes/#accessibility
https://www.w3.org/TR/wai-aria-practices-1.1/#checkbox
If you need help, call me.
I'll try to create demo for you and add the link here
from seliproject.
Functional Test failed!
Please, review your solution.
from seliproject.
This Feature is ready to be implemented.
from seliproject.
This Feature Request was accepted, but are not going to be implemented in next release.
This will be in #60 release
from seliproject.
This feature have been implemented and is ready for Funcional Test.
Please, test the feature.
from seliproject.
Functional Test failed!
Please, review your solution.
Tried to do a quiz using the screen reader and navigating the pag with tab, and encountered some errors:
https://drive.google.com/file/d/1xGDJ6RuHQtNobchU1-S-BoCZrssowMPl/view
-
0:08 - Screen reader does not read "Time limit: 01:01:01 minutes. Number of questions: 2. No award points"
-
0:09 -- When user selects "Start quiz" the screen reader says "Close SELI quiz"
-
0:13 - The "Cancel" and "Yes I'm sure" options are being read before the "Are you sure [...]"
-
0:44 - Answer options are not read unless when selected
-
0:50 - When navigating with tab the question is not read
-
1:30 - When user goes to the next page the screen reader doesn't read it, it reads only the "finish" button
-
Also in no moment que screen reader says the number of possible answers for each question
from seliproject.
@rebeccamello , @caroltaus the accessibility has been corrected according to the suggestions of its recipients, except with this requirement. "Also in no moment that screen reader says the number of possible answers for each question,"
Since the number of questions can be dynamic, it is not possible to implement this function using the accessibility tools of html or mataria UI, this information would have to be entered by the teacher or a function would have to be made that counts, which was not considered with Camila
from seliproject.
Functional Test passed!
Please, make a PULL REQUEST or, if already merged, close the issue.
from seliproject.
Functional Test failed!
Please, review your solution.
Please, move to CODED only when this feature is fully implemented
- bugs reported in comments are fixed
- requirements in OP are coded
If you want to request a test of some partial solution, add a comment here with test team @
- Remove "minutes" after the time limit
- "Next" button is not working
from seliproject.
This feature have been implemented and is ready for Funcional Test.
Please, test the feature.
from seliproject.
Functional Test failed!
Please, review your solution.
- When user finishes a quiz, the screen reader does not read "Are you sure you want to finish the quiz" nor the Yes or No options automatically, it only says "button".
- @ecureuill has coded an example using material UI and just html5 that reads the number of items, so you can use it to complete the missing task in #37 (comment)
https://so6du.csb.app/
from seliproject.
@caroltaus please check now
from seliproject.
This feature have been implemented and is ready for Funcional Test.
Please, test the feature.
from seliproject.
Functional Test failed!
Please, review your solution.
Everything is working well! except:
- When the screen reader first reads the entire page, the question is being read twice
- When the user selects "no" for "are you sure you want to finish the quiz?" the system crashes with a blank page
from seliproject.
This feature have been implemented and is ready for Funcional Test.
Please, test the feature.
from seliproject.
Functional Test failed!
Please, review your solution.
Now these pages are not being read automatically when the user first enters the page and neither is the page of the first question of the quiz. All the others are ok.
from seliproject.
- the pages in these screenshots (#37 (comment)) are still not being read automatically when the user first enters the page
from seliproject.
Hi @caroltaus I have reviewed everything about this part,
and it is not possible to make that the screen reader read the content of this component automatically, as it seems the problem is that the focus is lost since they are components reused from other parts of code and the javascript functions not to locate the focus do not work correctly,
about this screen, I tested it and the reader is automatically reading correctly
and finally about this : "when the screen reader reads the page automatically the "previous step" is not being read", I will fix it today and move the issue to coded
from seliproject.
Related Issues (20)
- Teacher's Profile HOT 1
- Turkish characters not accepted in "keyword" input in Information Step HOT 6
- Missing Turkish translation HOT 3
- Inclusion Goal tip phrase has a context error HOT 3
- Embedded storytelling video is playing automatic in Authoring Tool HOT 3
- Audio is being requested for all scenes HOT 8
- Image is being requested for all scenes HOT 9
- Should be possible to adjust layout on Program step
- Syllabus is crashing HOT 13
- Blank Pages: Improper handling of the errors HOT 1
- Can't insert an URL in H5P cmponent HOT 1
- H5P component's URL is not being validated HOT 1
- CORS policy is blocking external video on course HOT 4
- Illegal character in path segment of src attribute in video HOT 3
- Horizontal scrolling on delivery activity modal HOT 3
- FEAT [COMMENT'S BADGE] HOT 5
- Request for increase the number of keywords
- Course Preview page don't load if user is not authenticated HOT 2
- Translation Tracker HOT 4
- SELI Courses: filters doesn't work correctly
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from seliproject.