Giter Site home page Giter Site logo

Comments (11)

github-actions avatar github-actions commented on September 15, 2024

This Feature is ready to be implemented.

from seliproject.

ecureuill avatar ecureuill commented on September 15, 2024

Related commits

69c95ac
86bffb5

from seliproject.

github-actions avatar github-actions commented on September 15, 2024

This feature have been implemented and is ready for Funcional Test.
Plese, test the feature.

from seliproject.

github-actions avatar github-actions commented on September 15, 2024

Functional Test failed!
Please, review your solution.


@CAndresH Blocked by #41

from seliproject.

CAndresH avatar CAndresH commented on September 15, 2024

teacher configuration:
image

Scenario: Alert in Quiz with time constraint
GIVEN I'm doing a quiz
WHEN the system alert me that the time is almost out AND I have the option to extend time AND I click the option to extend time
THEN quiz time is extended
image

after clicking more time
image

Scenario: Extra time option for a Quiz with time constraint
GIVEN I select to start a quiz
WHEN I click the option to extend time
THEN quiz time is extended

image

you can click more time to add extra time if the option is enabled by the teacher

Scenario: No time option for a Quiz with time constraint
GIVEN I select to start a quiz
WHEN I click the option to disable time
THEN quiz time constraint is disabled.

image
you can click stop time time to disable the time if the option is enabled by the teacher

from seliproject.

github-actions avatar github-actions commented on September 15, 2024

This feature have been implemented and is ready for Funcional Test.
Please, test the feature.

from seliproject.

github-actions avatar github-actions commented on September 15, 2024

Functional Test failed!
Please, review your solution.


@CAndresH

  1. The alert is fixed in 00:01:00, this is not good for quiz that has time constraint of 00:01:00, also
    I talked with @Valfarinazzo and @MAmelia and they told me that for Instructional Design the best is to let teacher select the moment of the alert. So, could you add another accessibility configuration in #40 ?

Warning student when the time is running out (label)

00:00:30

ℹī¸ It's important that your student is warned when the time is finishing, for long duration quiz (>20min) it's suggested a warning at 10 min. For short duration, try at half of the time,

default value: half of the time constraint


  1. In a quiz configured to have extra-time option, when student select the extra-time option:

    1. Expected behavior: The timer must be updated at the moment that user select the option. Current behavior: The amount of extra-time is added to the timer, only after the time run-up.
    2. Expected behavior: The button to add more time should be disabled/removed. Current behavior: The user can add-up infinites amounts of extra-time.
  2. The alert model is not accessible and don't follow the same pattern of the platform. Use the alertdialog pattern to be accessible #51

Timer bugs

  1. In a quiz configured to have extra-time option, when student did not select the extra-time option and select continue in the alert and time run out

    1. The timer is set to 00:02:00 (extra-time) and stopped.
    2. After the 2 minutes (the extra-time) the time resumes.
    3. Then, when time run out, the quiz is closed.
      https://drive.google.com/open?id=1BQ9lxJRkp4razw_3PYJvJMKNFDnwcOve
  2. In a quiz configured to have extra-time option, when student did not select the extra-time option and do not close the alert and time run out

    1. The timer is set to 00:01:00 (extra-time).
    2. Then, when time run out, the quiz is closed.
      https://drive.google.com/open?id=1J2cbhVWwikAr8jR7gP3e8PU9R0X8XhB4

Intermittent bugs

  1. . In a quiz configured to have extra-time or no-time option, the quiz functionality is broken. I think this happens for quizzes that the time run out once
    1. A new question "page" is added at the end (see the picture)
    1. The button to finish the quiz is omitted
    image

  2. After some 3-5 seconds opened the quiz closes. It seems to occurs only for quizzes that has results (was finished by user or when times run out).

browser console output:

error: CourseContent.js:423 fromTutor 4 undefined
messages:
QuizItem.js:145 en el student
QuizItem.js:271 this.state.quizResult {expanded: "quiz-panel", resolved: false, time: 300000}expanded: "quiz-panel"resolved: falsetime: 300000__proto__: Object
QuizItem.js:145 en el student
QuizItem.js:271 this.state.quizResult {expanded: "quiz-panel", resolved: false, time: 60000}expanded: "quiz-panel"resolved: falsetime: 60000__proto__: Object
QuizItem.js:145 en el student
QuizItem.js:271 this.state.quizResult {expanded: "quiz-panel", resolved: false, time: 60000}expanded: "quiz-panel"resolved: falsetime: 60000__proto__: Object
QuizItem.js:145 en el student
QuizItem.js:271 this.state.quizResult {expanded: "quiz-panel", resolved: false, time: 60000}expanded: "quiz-panel"resolved: falsetime: 60000__proto__: Object
QuizItem.js:145 en el student
QuizItem.js:271 this.state.quizResult {expanded: "quiz-panel", resolved: true, time: 300000}expanded: "quiz-panel"resolved: truetime: 300000__proto__: Object
QuizItem.js:145 en el student
QuizItem.js:271 this.state.quizResult {expanded: "quiz-panel", resolved: true, time: 60000}expanded: "quiz-panel"resolved: truetime: 60000__proto__: Object
QuizItem.js:145 en el student
QuizItem.js:271 this.state.quizResult {expanded: "quiz-panel", resolved: true, time: 60000}expanded: "quiz-panel"resolved: truetime: 60000__proto__: Object
QuizItem.js:145 en el student
QuizItem.js:271 this.state.quizResult {expanded: "quiz-panel", resolved: true, time: 60000}expanded: "quiz-panel"resolved: truetime: 60000__proto__: Object

from seliproject.

github-actions avatar github-actions commented on September 15, 2024

This feature have been implemented and is ready for Funcional Test.
Please, test the feature.


@caroltaus please check if all scenarios of the feature is coded and review if the bugs (#39 (comment)) was solved.

Must be tested together with #38 #40

from seliproject.

CAndresH avatar CAndresH commented on September 15, 2024

Please review the solution if possible in the develop branch:
following the recommendations and considering requirement #41 40, the accessibility settings are in form #3 and there are tips and feedbacks . the teacher can configure the alert time in the test, if accessibility is not configured the alert time assumes default values: (It's important that your student is warned when the time is finishing, for long duration quiz (> 20min) it's suggested a warning at 10 min. For short duration, try at half of the time, default value: half of the time constraint) likewise other time related bugs were fixed, new packages were added don't forget to do npm install

from seliproject.

github-actions avatar github-actions commented on September 15, 2024

Functional Test passed!
Please, make a PULL REQUEST.

from seliproject.

github-actions avatar github-actions commented on September 15, 2024

This Feature Request was accepted and is ready for specfication.

from seliproject.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤ī¸ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.