[Bug?]: Plugin types, typescript issues

[birkskyum]

[Bug?]: Plugin types, typescript issues

[ryansolid]

I think this is just fixed in the next version with the Vite 5 update.. I wasn't able to reproduce it at least on that branch.

I went back to main (Vite 4) and I see the Plugin_2 alias but it also isn't screaming red lines at me. So I don't know.

[birkskyum]

The VitePWA returns a standard rollup Plugin:

interface Plugin<A = any> extends rollup.Plugin<A>

And the solid start expect a PluginOption defined in this convoluted way due to overloading:

export declare type PluginOption = Plugin_2 | false | null | undefined | PluginOption[] | Promise<Plugin_2 | false | null | undefined | PluginOption[]>;

declare interface Plugin_2 extends Plugin_3

where Plugin_3 is the rollup plugin type;

import type { Plugin as Plugin_3 } from 'rollup';

This is an area that has been refactored inside of Vite, so it's likely easier to wrap the head around after, as there appear to be conflict between vite 4 (solid start) and vite 5 (vite pwa plugin) types:

• #1331