Giter Site home page Giter Site logo

Comments (5)

doeixd avatar doeixd commented on July 26, 2024 1

Related Issue

from solid-start.

illiaChaban avatar illiaChaban commented on July 26, 2024

Update: if i pass a function that returns JSXElement instead of JSXElement instead, it works
Although i don't think it's a fully expected behavior and I would still expect passing JSXElements to work
i.e

<Separate items={[() => <span>Hello</span>, () => <span>world</span>]} />

from solid-start.

mdynnl avatar mdynnl commented on July 26, 2024

This is expected with current state of hydration.

<Separate items={[<span>Hello</span>, <span>world</span>]} />

compiles to

_$createComponent(Separate, {
  get items() {
    return [_tmpl$(), _tmpl$2()];
  }
})

and accessing p.items generates new elements.
as far as the hydration is concerned, there is nothing wrong with that as long as these elements can be found in the DOM.

👉 But new elements created while evaluating p.items.length won't exist in the dom hence the hydration error.

i() === p.items.length - 1 ? <>{item}</> : <>{item}</>

this doesn't happen with

<Separate items={[() => <span>Hello</span>, () => <span>world</span>]} />

or

/* 🛑 use at your own risk */
const items = [<span>Hello</span>, <span>world</span>]
<Separate items={items} /> // no getter

or

function Separate(p) {
	/* ❌ don't do this */
	const items = p.items // just for the sake of the point

	const slightlyCorrect = createMemo(() => p.items)

	/* ✅ do this */
	const correct = children(() => p.items)
}

from solid-start.

illiaChaban avatar illiaChaban commented on July 26, 2024

@mdynnl how is this expected? From the DX point of view it doesn't make much sense and this behavior is not documented anywhere.
Thanks for explaining on why it doesn't work due to some internal implementation details, however, IMO this is not an expected behavior, since i would expect SSR and SPA versions of Solid to work the same way

from solid-start.

illiaChaban avatar illiaChaban commented on July 26, 2024

why can't i generate a new elements and not append them to the DOM? Why can't they be hydrated as part of the javascript?

from solid-start.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.