Extract Descendants + TypeLookup into a separate gem

[solnic]

Extract Descendants + TypeLookup into a separate gem

[dkubb]

🤘

[solnic]

@dkubb would you agree that both should go to the same gem? Does Veritas need type lookup?

[dkubb]

@solnic I probably need to think about it for a bit. I believe Veritas has a simple descendants + type lookup system, and it was for mostly the same reasons.. I map primitive objects onto Veritas::Attribute subclasses and choose the best match for a given primitive.

[solnic]

@dkubb yeah that's what I thought so. It's definitely a common pattern for both libs.

[solnic]

@dkubb right, so it seems like Veritas::Attribute has a very similar implementation of #descendants as we have in Virtus. I'm thinking about extracting this stuff (along with TypeLookup) to a gem called maybe just "descendants". WDYT?

[trans]

Might it be something that Ruby could/should support out of the box? If so suggest it for future version.

[dkubb]

The way we wrote descendants was to complement ancestors which is supplied by ruby stdlib. I would love for Ruby to support it natively, maybe we should suggest it. OTOH I am a bit concerned with other things getting added for 2.0 so I am a bit reluctant.

[solnic]

I would love to get this done for 0.5.0. @dkubb are you willing to do it? it would be nice since it's basically your code if I remember correctly :)

[dkubb]

@solnic I'm focused on making veritas relations writable. I don't think this is a super high priority task; not enough to put veritas work on hold atm.

In general almost everything in the "support" lib of both veritas and virtus could probably be split out into stand-alone libraries (that's kind of the criteria for something to live in that directory). We could hold those extraction projects back as good lead-in projects for people wanting to contribute to DM2 development. They're tiny, already include lots of docs and tests, and provide people a good way to get involved without too much overhead. Plus they allow people to learn the way we're structuring the project (like "rake ci") without compromising the structure of the core system. In short, I think they're perfect way to introduce people to DM2 development.

[dkubb]

I should mention that assuming no one picks up these projects, I plan to circle back to them when I run out of steam on some of the more complex parts of DM2. I usually have a couple of low complexity tasks set side for when I'm tired or burnt out (or coming back from a burn-out), and if no one picks these up I'll probably keep them as "active rest" type projects.

[senny]

@dkubb I am willing to help wherever I can to move the DM2 project forward. If this is something you like the see done, please let me know what you expect and what guidelines to follow. I would be pleased to help.

[solnic]

Closing as descendants tracker is already extracted.

[mbj]

Extracted to: dkubb/descendants_tracker