why does this bundle depend on Sonata Admin Bundle?

[sonata-project]

why does this bundle depend on Sonata Admin Bundle?

[rande]

The dependency is optional: https://github.com/sonata-project/SonataBlockBundle/blob/master/composer.json#L30-L34

[gondo]

well what about this https://github.com/sonata-project/SonataBlockBundle/blob/master/composer.json#L28 ?

[gondo]

also there are use statements all over the code linking to AdminBundle https://github.com/sonata-project/SonataBlockBundle/search?q=Admin

[gondo]

funny enough search for AdminBundle doesn't show anything. i have no idea how github search works. https://github.com/sonata-project/SonataBlockBundle/search?q=AdminBundle

[rande]

require-dev is used for unit testing, if you develop a project with stability=dev then you will have the dependency. So use stable version ...

You can have a use statement on non existent class, this is valid as long as you don't call a method with a type hinting on this method.

[Miliooo]

I'm also strongly considering trying out this bundle in a project after seeing http://www.slideshare.net/th0masr/sonata-block-bundle-sfpot-march-2014.

But I'm not sure how easy it will be to workaround the fact that the

• BlockServiceManagerInterface and the
• BaseBlockService

both have methods that require the sonata admin bundle.
As can be seen in https://github.com/sonata-project/SonataBlockBundle/search?p=2&q=Admin

I haven't even tried the bundle so I'm not even sure it will be an issue at all... I just agree with gondo that this bundle should not depend on the adminbundle. Not being able to call methods in an interface because they require an optional bundle is not ideal.

[rande]

Methods are not used if the AdminBundle is not present. So what's is the problem ?