Comments (2)
rsandell
commented on July 30, 2024
When you say returned by HTTP what do you mean? Is it an HTTP variant of stream-events like a websocket or is it the format of the web hook or something else?
Seeing as you are talking about the querry handler I'm guessing the something else :)
I think alternative 1 would be OK. But leave the original methods as is to retain binary backwards compatibility and behaviour.
from gerrit-events.
rsandell
commented on July 30, 2024
The original querry handler should likewise also stay and behave like it used to.
Maybe adding a static factory method to create an http or ssh version would work?
from gerrit-events.
Related Issues (20)
- [Refactor] Use data binding library
- Test fails in some time.
- Proposition of architecture. HOT 1
- How to add topic event into gerrit events HOT 4
- Add the ability to read the output and if interactive shells are disabled on Gerrit HOT 1
- How to detect if gerrit connection is alive? HOT 2
- Connections possibly left unclosed HOT 7
- fast events create invalid JSON data HOT 1
- Missing Parameter for eventCreatedOn in Gerrit Event Json Message
- Found starting '{' but missing '}' at the end.
- Objects in package com.sonymobile.tools.gerrit.gerritevents.dto.events should have a Constructor with JSONObject as parameter HOT 6
- Gerrit Trigger SSH often gets stuck in CLOSED WAITING HOT 4
- Gerrit Events not causing a trigger HOT 1
- CommentAdded events considered equal even if they are different comments
- Using the default value of timeout=0 when creating SSH connections might lead to threads stuck forever HOT 2
- No support for ED25519 keys (replace JSCH library) HOT 3
- Topic Changed Event does not propagate patch set HOT 5
- Missing AttentionSet changes events
- Deadlock when shutting down while establishing connection
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gerrit-events.