Giter Site home page Giter Site logo

Comments (6)

farhanmalhi-dbank avatar farhanmalhi-dbank commented on August 13, 2024 2

@sebastianvitterso Yes, you are right on this. Lets just wait for any update on Strict mode and I am closing this issue. If later on i found any fix or any update beneficial for this issue. I'll post.

from react-oauth2-pkce.

farhanmalhi-dbank avatar farhanmalhi-dbank commented on August 13, 2024

@soofstad Just an update which i figured out, the cause of this is

root.render(
  <React.StrictMode>
    <App />
  </React.StrictMode>
);

i.e if we use React.StrictMode which makes react components render twice and due to this Token endpoint is called twice.
Please fix this
Thanks

from react-oauth2-pkce.

soofstad avatar soofstad commented on August 13, 2024

This is how StrictMode works for react 18 at the moment. With no way of disabling it for specific components (ref: facebook/react#16362).

Any suggestions to how this could be solved are welcome.

from react-oauth2-pkce.

sebastianvitterso avatar sebastianvitterso commented on August 13, 2024

Just to add to this: According to Dan Abramov (co-author of create-react-app), these duplicated requests should pose no issue, and only happen in development mode. If you try and bundle your app, and then run the bundled code, your requests should only happen once. This is apparently an intentional of React 18 <StrictMode />.

Source: facebook/react#24502 (comment)

from react-oauth2-pkce.

farhanmalhi-dbank avatar farhanmalhi-dbank commented on August 13, 2024

@sebastianvitterso Yes, i agree. It only happens in development mode.

from react-oauth2-pkce.

sebastianvitterso avatar sebastianvitterso commented on August 13, 2024

Good to verify! I don't think there's anything this library can do to remedy this effect (considering it is a deliberate function of StrictMode). Feel free to close the issue, unless there's anything else.

from react-oauth2-pkce.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.