Comments (6)
@sebastianvitterso Yes, you are right on this. Lets just wait for any update on Strict mode and I am closing this issue. If later on i found any fix or any update beneficial for this issue. I'll post.
from react-oauth2-pkce.
@soofstad Just an update which i figured out, the cause of this is
root.render(
<React.StrictMode>
<App />
</React.StrictMode>
);
i.e if we use React.StrictMode which makes react components render twice and due to this Token endpoint is called twice.
Please fix this
Thanks
from react-oauth2-pkce.
This is how StrictMode works for react 18 at the moment. With no way of disabling it for specific components (ref: facebook/react#16362).
Any suggestions to how this could be solved are welcome.
from react-oauth2-pkce.
Just to add to this: According to Dan Abramov (co-author of create-react-app), these duplicated requests should pose no issue, and only happen in development mode. If you try and bundle your app, and then run the bundled code, your requests should only happen once. This is apparently an intentional of React 18 <StrictMode />
.
Source: facebook/react#24502 (comment)
from react-oauth2-pkce.
@sebastianvitterso Yes, i agree. It only happens in development mode.
from react-oauth2-pkce.
Good to verify! I don't think there's anything this library can do to remedy this effect (considering it is a deliberate function of StrictMode). Feel free to close the issue, unless there's anything else.
from react-oauth2-pkce.
Related Issues (20)
- 💡 [REQUEST] - Add ability to add headers to requests HOT 6
- 💡 [REQUEST] - Scope parameter is not supported on an authorization code access_token exchange request HOT 8
- Bug: Client authentication with confidential access isn't working HOT 6
- Bug: Redirects replace instead of creating a history entry HOT 2
- 💡 [REQUEST] - Parse (refresh) token expiration from token payload HOT 5
- 💡 [REQUEST] - Refresh access token without resetting the refresh token HOT 1
- Bug: "codeVerifier" and "state" are stored in sessionStorage despite "storage" parameter being "local" HOT 4
- Bug: Does not work correctly if routing type is hash HOT 2
- 💡 [Feature] - Ability to send custom headers in the authorization, token requests HOT 6
- 💡 [REQUEST] - Pass extra parameters to login()-function
- 💡 [FEATURE] - Option in login()-function to not redirect, but instead do it in an iframe or popup HOT 1
- 💡 [REQUEST] - Enhance Logout Functionality HOT 2
- 💡 [Feature] - `postLogout`-callback HOT 2
- 💡 [Feature] - Allow for passing arbitrary arguments to `logOut()`
- Bug: codeVerifier is not set in sessionStorage (sometimes) HOT 4
- Bug: Refresh token has a fixed expiration time HOT 1
- /authorized?code complains 404 Not Found HOT 1
- Bug: Token is cleared before Logout HOT 4
- Bug: refreshAccessToken is only called once
- Bug: "Bad authorization state" error on subsequent visits to login page. HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-oauth2-pkce.